-
Notifications
You must be signed in to change notification settings - Fork 30.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crypto: check for nullptr before dereferencing identity_buf #57071
base: main
Are you sure you want to change the base?
Conversation
Review requested:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #57071 +/- ##
==========================================
- Coverage 90.37% 90.26% -0.11%
==========================================
Files 629 630 +1
Lines 184365 184634 +269
Branches 36016 36131 +115
==========================================
+ Hits 166612 166666 +54
- Misses 10918 11025 +107
- Partials 6835 6943 +108
|
Don't know how to test this since any js code would have its argument validated before moving to the C++ side |
This comment was marked as outdated.
This comment was marked as outdated.
Rebased |
This comment was marked as outdated.
This comment was marked as outdated.
CI failures seem unrelated? |
This comment was marked as outdated.
This comment was marked as outdated.
Yeah seems to be random this CI failure, it was linux and now it's macos |
The js-side already checks for this so the test already passes, so I don't think it's a vulnerability
Just in case, added the check for future
Fix #56665