Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v22.x backport] deps: update libuv to 1.50.0 #57316

Open
wants to merge 1 commit into
base: v22.x-staging
Choose a base branch
from

Conversation

juanarbol
Copy link
Member

@juanarbol juanarbol commented Mar 4, 2025

PR-URL: #56616
Backport-PR-URL: #57316
Reviewed-By: Rafael Gonzaga [email protected]
Reviewed-By: Colin Ihrig [email protected]
Reviewed-By: Juan José Arboleda [email protected]
Reviewed-By: Santiago Gimeno [email protected]
Reviewed-By: Luigi Pinca [email protected]
Reviewed-By: Ulises Gascón [email protected]
Reviewed-By: Richard Lau [email protected]


I had 0 problems locally, I'll kick a CI

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added libuv Issues and PRs related to the libuv dependency or the uv binding. needs-ci PRs that need a full CI run. v22.x v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch. labels Mar 4, 2025
@nodejs-github-bot
Copy link
Collaborator

PR-URL: nodejs#56616
Backport-PR-URL: nodejs#57316
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@nodejs-github-bot
Copy link
Collaborator

@richardlau
Copy link
Member

This still has the same CI failures as #56616 (comment). Most likely this version of libuv has broken something on 32-bit Windows. We no longer build on 32-bit Windows for Node.js 23 which is why this would not have been noticed until attempting to land on Node.js 22 (where we still test and release on 32-bit Windows).

cc @nodejs/libuv @nodejs/platform-windows

@bnoordhuis
Copy link
Member

I only see this error. Are there more?

  + 'ERR_FS_EISDIR'
  - 'ERR_FS_CP_EINVAL'

That's node's wrapper around uv_fs_copyfile(), right? The new error code seems more appropriate, doesn't it?

@targos
Copy link
Member

targos commented Mar 6, 2025

On 32-bit Windows, the error is:

> python tools\test.py --mode=release  --flaky-tests=dontcare --run=0,4 --measure-flakiness 9 -p tap --logfile test.tap default pummel 
Can't determine the arch of: 'C:\workspace\node-test-binary-windows-js-suites\node\Release\node.exe'

Coming from

node/tools/test.py

Lines 1708 to 1713 in 2a6f908

archEngineContext = Execute([vm, "-p", "process.arch"], context)
vmArch = archEngineContext.stdout.rstrip()
if archEngineContext.exit_code != 0 or vmArch == "undefined":
print("Can't determine the arch of: '%s'" % vm)
print(archEngineContext.stderr.rstrip())
continue

@juanarbol
Copy link
Member Author

I'll spin a VM and inspect. Please do not expect anything, I do this on my spare time

@juanarbol
Copy link
Member Author

juanarbol commented Mar 6, 2025

Can anyone from @nodejs/build help me out setting up the box? I haven't be able to setup visual studio, not even with Boxstarter. Apparently 32bits vs stuff is not longer distributed or something.

Refs: https://github.com/nodejs/node/blob/main/BUILDING.md#option-3-automated-install-with-boxstarter

VirtualBox_win10-32bits_06_03_2025_14_36_19

@anonrig
Copy link
Member

anonrig commented Mar 9, 2025

Cc @nodejs/platform-windows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
libuv Issues and PRs related to the libuv dependency or the uv binding. needs-ci PRs that need a full CI run. v22.x v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants