-
Notifications
You must be signed in to change notification settings - Fork 30.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v22.x backport] deps: update libuv to 1.50.0 #57316
base: v22.x-staging
Are you sure you want to change the base?
[v22.x backport] deps: update libuv to 1.50.0 #57316
Conversation
Review requested:
|
PR-URL: nodejs#56616 Backport-PR-URL: nodejs#57316 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ulises Gascón <[email protected]> Reviewed-By: Richard Lau <[email protected]>
cf9a573
to
c80bee4
Compare
This still has the same CI failures as #56616 (comment). Most likely this version of libuv has broken something on 32-bit Windows. We no longer build on 32-bit Windows for Node.js 23 which is why this would not have been noticed until attempting to land on Node.js 22 (where we still test and release on 32-bit Windows). cc @nodejs/libuv @nodejs/platform-windows |
I only see this error. Are there more?
That's node's wrapper around |
On 32-bit Windows, the error is:
Coming from Lines 1708 to 1713 in 2a6f908
|
I'll spin a VM and inspect. Please do not expect anything, I do this on my spare time |
Can anyone from @nodejs/build help me out setting up the box? I haven't be able to setup visual studio, not even with Boxstarter. Apparently 32bits vs stuff is not longer distributed or something. Refs: https://github.com/nodejs/node/blob/main/BUILDING.md#option-3-automated-install-with-boxstarter |
Cc @nodejs/platform-windows |
PR-URL: #56616
Backport-PR-URL: #57316
Reviewed-By: Rafael Gonzaga [email protected]
Reviewed-By: Colin Ihrig [email protected]
Reviewed-By: Juan José Arboleda [email protected]
Reviewed-By: Santiago Gimeno [email protected]
Reviewed-By: Luigi Pinca [email protected]
Reviewed-By: Ulises Gascón [email protected]
Reviewed-By: Richard Lau [email protected]
I had 0 problems locally, I'll kick a CI