tls: remove unnecessary type check on normalize #57336
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
jasnell
reviewed
Mar 5, 2025
| @@ -1655,7 +1655,7 @@ function normalizeConnectArgs(listArgs) { | |||
| // This means that options.host overrides a host arg. | |||
| if (listArgs[1] !== null && typeof listArgs[1] === 'object') { | |||
| ObjectAssign(options, listArgs[1]); | |||
| } else if (listArgs[2] !== null && typeof listArgs[2] === 'object') { | |||
| } else { | |||
There was a problem hiding this comment.
Specifically... for those who are unaware... Object.assign(options, ...) works successfully for any value type.. That is, Object.assign(options, null) still works as expected.
That said... @anonrig ... the same applies for the line above also... that can probably be simplified also.
jasnell
approved these changes
Mar 5, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #57336 +/- ##
==========================================
- Coverage 90.19% 90.19% -0.01%
==========================================
Files 630 630
Lines 185195 185195
Branches 36249 36244 -5
==========================================
- Hits 167036 167032 -4
+ Misses 11132 11131 -1
- Partials 7027 7032 +5
🚀 New features to boost your workflow:
|
anonrig
added
author ready
github-actions
bot
removed
the
request-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on @jasnell's recommendation: cloudflare/workerd#3594 (comment)