sqlite: reset statement immediately in run() #57350
Open
+22
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates StatementSync.prototype.run() to reset the prepared statement immediately after calling sqlite3_step() to return the correct change metadata. Fixes: nodejs#57344
|
Review requested:
|
nodejs-github-bot
added
c++
geeksilva97
approved these changes
Mar 6, 2025
tpoisseau
approved these changes
Mar 6, 2025
geeksilva97
added
author ready
github-actions
bot
removed
the
request-ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #57350 +/- ##
==========================================
- Coverage 90.19% 90.18% -0.02%
==========================================
Files 630 630
Lines 185187 185185 -2
Branches 36243 36245 +2
==========================================
- Hits 167030 167002 -28
+ Misses 11131 11130 -1
- Partials 7026 7053 +27
🚀 New features to boost your workflow:
|
louwers
approved these changes
Mar 6, 2025
cjihrig
added
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/57350 ✔ Done loading data for nodejs/node/pull/57350 ----------------------------------- PR info ------------------------------------ Title sqlite: reset statement immediately in run() (#57350) Author Colin Ihrig <[email protected]> (@cjihrig) Branch cjihrig:bug -> nodejs:main Labels c++, author ready, sqlite Commits 1 - sqlite: reset statement immediately in run() Committers 1 - cjihrig <[email protected]> PR-URL: https://github.com/nodejs/node/pull/57350 Fixes: https://github.com/nodejs/node/issues/57344 Reviewed-By: Edy Silva <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/57350 Fixes: https://github.com/nodejs/node/issues/57344 Reviewed-By: Edy Silva <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 06 Mar 2025 15:17:50 GMT ✔ Approvals: 1 ✔ - Edy Silva (@geeksilva97): https://github.com/nodejs/node/pull/57350#pullrequestreview-2664814350 ✘ This PR needs to wait 119 more hours to land (or 0 hours if there is one more approval) ✔ Last GitHub CI successful ℹ Last Full PR CI on 2025-03-06T19:40:56Z: https://ci.nodejs.org/job/node-test-pull-request/65618/ - Querying data for job/node-test-pull-request/65618/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/13738933344 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates
StatementSync.prototype.run()to reset the prepared statement immediately after callingsqlite3_step()to return the correct change metadata.Fixes: #57344
This matches the better-sqlite3 implementation.