-
Notifications
You must be signed in to change notification settings - Fork 30.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src: do not pass nullptr
to std::string
ctor
#57354
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
ckerr:fix/dont-pass-nullptr-to-std-string-ctor
Mar 9, 2025
Merged
src: do not pass nullptr
to std::string
ctor
#57354
nodejs-github-bot
merged 1 commit into
nodejs:main
from
ckerr:fix/dont-pass-nullptr-to-std-string-ctor
Mar 9, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes -Wnonnull warning on some compilers
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #57354 +/- ##
=======================================
Coverage 90.21% 90.21%
=======================================
Files 630 630
Lines 185304 185304
Branches 36261 36266 +5
=======================================
+ Hits 167178 167179 +1
- Misses 11082 11084 +2
+ Partials 7044 7041 -3
🚀 New features to boost your workflow:
|
daeyeon
approved these changes
Mar 7, 2025
anonrig
approved these changes
Mar 7, 2025
legendecas
approved these changes
Mar 7, 2025
codebytere
approved these changes
Mar 7, 2025
nullptr
to std::string
ctor
lpinca
approved these changes
Mar 7, 2025
addaleax
approved these changes
Mar 8, 2025
Landed in 9a9a45a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
c++
Issues and PRs that require attention from people who are familiar with C++.
debugger
Issues and PRs related to the debugger subsystem.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes this error that I hit when working on a Chromium bump today in Electron:
This code has been around for awhile in Node.js, so the new build failure is probably an Electron issue, e.g. CI config.
Even so, upstreaming a fix feels worthwhile since building a
std::string
fromnullptr
is undefined behavior in C++20 and is prohibited as of C++23.This PR just replaces the
return nullptr;
with areturn {};
in a function that returns astd::string
.CC @codebytere