test_runner: change ts default glob

[marco-ippolito]

This PR changes the default glob for matching.ts files.
Basically will match only *test.{ts,mts,cts} inside the test folder.
This is the safest and middle ground to avoid breaking users.
I'd not consider a breaking change in v23 since typescript support is experimental.

Fixes: #56546

[nodejs-github-bot]

Review requested:

• @nodejs/test_runner

[codecov]

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.21%. Comparing base (4cc69f9) to head (464688e).
Report is 15 commits behind head on main.

Files with missing lines	Patch %	Lines
lib/internal/test_runner/utils.js	66.66%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #57359      +/-   ##
==========================================
+ Coverage   90.20%   90.21%   +0.01%     
==========================================
  Files         630      630              
  Lines      185307   185307              
  Branches    36271    36267       -4     
==========================================
+ Hits       167160   167181      +21     
- Misses      11085    11089       +4     
+ Partials     7062     7037      -25     

Files with missing lines	Coverage Δ
lib/internal/test_runner/runner.js	89.02% <100.00%> (-0.49%)	⬇️
lib/internal/test_runner/utils.js	58.66% <66.66%> (ø)

... and 22 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[mcollina]

lgtm

I have a rough feeling this is semver-major.

[marco-ippolito]

Since ts is experimental its should be fine, also from my pov we are fixing a bug.
For example by matching all .ts, it was matching also .d.ts.
I know it might break some people but this is a much safer default

[mcollina]

lgtm

[mcollina]

@marco-ippolito ok

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/65632/

[JakobJingleheimer]

For v24.0, can we remove the restriction requiring a test folder?

[marco-ippolito]

I think the issue is that people keep their test.ts in the src folder and transpile them, so they will be executed twice.
Once node v20 goes EOL we can be more lax and include other patterns

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/65636/

[ShogunPanda]

LGTM!

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/65645/

[nodejs-github-bot]

Landed in 9df0ff7