Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update WPT for WebCryptoAPI to edd42c005c #57365

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

nodejs-github-bot
Copy link
Collaborator

This is an automated update of the WPT for WebCryptoAPI to web-platform-tests/wpt@edd42c0.

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Mar 7, 2025
@nodejs-github-bot
Copy link
Collaborator Author

Review requested:

  • @nodejs/web-standards

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Mar 7, 2025
@panva panva changed the title test: update WPT for WebCryptoAPI to edd42c005c crypto: update WebCryptoAPI Ed25519/448 JWK alg handling Mar 7, 2025
@panva panva added crypto Issues and PRs related to the crypto subsystem. webcrypto commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. request-ci Add this label to start a Jenkins CI on a PR. and removed test Issues and PRs related to the tests. request-ci Add this label to start a Jenkins CI on a PR. labels Mar 7, 2025
@panva

This comment was marked as outdated.

@panva
Copy link
Member

panva commented Mar 7, 2025

I've pushed a commit to this PR to fix the behaviours that would otherwise fail the updated WPT.

Copy link

codecov bot commented Mar 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.21%. Comparing base (27f98c3) to head (8d55707).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #57365      +/-   ##
==========================================
+ Coverage   90.20%   90.21%   +0.01%     
==========================================
  Files         630      630              
  Lines      185307   185316       +9     
  Branches    36269    36268       -1     
==========================================
+ Hits       167162   167189      +27     
+ Misses      11084    11076       -8     
+ Partials     7061     7051      -10     
Files with missing lines Coverage Δ
lib/internal/crypto/cfrg.js 97.33% <100.00%> (+0.05%) ⬆️
lib/internal/crypto/webcrypto.js 96.19% <100.00%> (+<0.01%) ⬆️

... and 31 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@panva panva added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 7, 2025
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot nodejs-github-bot changed the title crypto: update WebCryptoAPI Ed25519/448 JWK alg handling test: update WPT for WebCryptoAPI to edd42c005c Mar 8, 2025
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot
Copy link
Collaborator Author

@panva panva added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. webcrypto
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants