lib: make getCallSites sourceMap option truly optional #57388
+20
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling the
util.getCallSites(...)
API, if theoptions
argument is omitted, then theoptions.sourceMap
option is defaulted to false. However, if any emptyoptions
is passed, it would throw an error ifsourceMap
was not explicitly given. This relaxes that so thatsourceMap
can be left unspecified.For instance, before this commit,
getCallSites({})
would throw an error.Also, add more test coverage of this.