esm: synchronise default path of ModuleLoader.load
#57390
Conversation
|
Review requested:
|
nodejs-github-bot
added
esm
| context = { __proto__: context, source }; | ||
| } | ||
|
|
||
| if (format == null) { | ||
| // Now that we have the source for the module, run `defaultGetFormat` to detect its format. | ||
| format = await defaultGetFormat(urlInstance, context); | ||
| format = defaultGetFormat(urlInstance, context); |
There was a problem hiding this comment.
defaultGetFormat is already sync
JakobJingleheimer
changed the title
ModuleLoaderModuleLoader.load
JakobJingleheimer
changed the title
ModuleLoader.loadModuleLoader.load
| const { readFile: readFileAsync } = require('internal/fs/promises').exports; | ||
| source = await readFileAsync(url); | ||
| source = readFileSync(url); |
There was a problem hiding this comment.
This converts to a blocking op, but I'm not sure if that matters.
There was a problem hiding this comment.
The CommonJS loadSource uses readFileSync:
node/lib/internal/modules/cjs/loader.js
Line 1128 in fbe37d5
though CommonJS is fundamentally sync. I think it should be fine to use the same in ESM; @joyeecheung or anyone else, do you have any concerns?
There was a problem hiding this comment.
+1 to the effort. Tracking issue: #55782
We should also find some benchmarks that measure the performance impact of the overall syncification effort. Perhaps the existing ESM benchmarks are sufficient?
| const { readFile: readFileAsync } = require('internal/fs/promises').exports; | ||
| source = await readFileAsync(url); | ||
| source = readFileSync(url); |
There was a problem hiding this comment.
The CommonJS loadSource uses readFileSync:
node/lib/internal/modules/cjs/loader.js
Line 1128 in fbe37d5
though CommonJS is fundamentally sync. I think it should be fine to use the same in ESM; @joyeecheung or anyone else, do you have any concerns?
No description provided.