Skip to content

src: disable abseil deadlock detection #57582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 2, 2025
Merged

src: disable abseil deadlock detection #57582

merged 2 commits into from
Apr 2, 2025

Conversation

legendecas
Copy link
Member

@legendecas legendecas commented Mar 21, 2025 •
edited
Loading

Abseil deadlock detection is reporting false positives in tests in V8.
Abseil mutexes are not used in node core, so disable it for now.

Refs: nodejs/node-v8#301

@legendecas
src: disable abseil deadlock detection
a5d3f79 
Abseil deadlock detection is reporting false positives in tests.
Disable it for now.
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/startup

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Mar 21, 2025
@imronsman

This comment was marked as off-topic.

Sign in to view
@codecov Codecov
Copy link

codecov bot commented Mar 21, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.22%. Comparing base (8b2098f) to head (8193761).
Report is 328 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #57582      +/-   ##
==========================================
- Coverage   90.22%   90.22%   -0.01%     
==========================================
  Files         630      630              
  Lines      185045   185055      +10     
  Branches    36243    36247       +4     
==========================================
+ Hits       166961   166963       +2     
- Misses      11034    11037       +3     
- Partials     7050     7055       +5
Files with missing lines Coverage Δ
src/node.cc 73.55% <100.00%> (+0.03%) ⬆️

... and 36 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@targos
Copy link
Member

targos commented Mar 21, 2025

Windows build error:

 abseil.lib(per_thread_sem.obj) : error LNK2019: unresolved external symbol "public: __cdecl absl::synchronization_internal::Win32Waiter::Win32Waiter(void)" (??0Win32Waiter@synchronization_internal@absl@@QEAA@XZ) referenced in function AbslInternalPerThreadSemInit [D:\a\node\node\node_mksnapshot.vcxproj]
abseil.lib(per_thread_sem.obj) : error LNK2019: unresolved external symbol "public: bool __cdecl absl::synchronization_internal::Win32Waiter::Wait(class absl::synchronization_internal::KernelTimeout)" (?Wait@Win32Waiter@synchronization_internal@absl@@QEAA_NVKernelTimeout@23@@Z) referenced in function AbslInternalPerThreadSemWait [D:\a\node\node\node_mksnapshot.vcxproj]
abseil.lib(per_thread_sem.obj) : error LNK2019: unresolved external symbol "public: void __cdecl absl::synchronization_internal::Win32Waiter::Post(void)" (?Post@Win32Waiter@synchronization_internal@absl@@QEAAXXZ) referenced in function AbslInternalPerThreadSemPost [D:\a\node\node\node_mksnapshot.vcxproj]
abseil.lib(per_thread_sem.obj) : error LNK2019: unresolved external symbol "public: void __cdecl absl::synchronization_internal::Win32Waiter::Poke(void)" (?Poke@Win32Waiter@synchronization_internal@absl@@QEAAXXZ) referenced in function "public: static void __cdecl absl::synchronization_internal::PerThreadSem::Tick(struct absl::base_internal::ThreadIdentity *)" (?Tick@PerThreadSem@synchronization_internal@absl@@SAXPEAUThreadIdentity@base_internal@3@@Z) [D:\a\node\node\node_mksnapshot.vcxproj]
out\Release\node_mksnapshot.exe : fatal error LNK1120: 4 unresolved externals [D:\a\node\node\node_mksnapshot.vcxproj]

Looks like we need this change from 3d1fe71#diff-7ec0a6942f03ad6ff24215a31b1b45a378ee21b2cba5f79937281c5f5528d2bf

image

@targos targos mentioned this pull request Mar 22, 2025
Closed
6 tasks
@targos targos added request-ci Add this label to start a Jenkins CI on a PR. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Apr 1, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 1, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65939/

@targos targos added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 2, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 2, 2025
@nodejs-github-bot nodejs-github-bot merged commit 78af51c into nodejs:main Apr 2, 2025
63 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 78af51c

@legendecas legendecas deleted the abseil-deadlock branch April 2, 2025 09:31
JonasBa pushed a commit to JonasBa/node that referenced this pull request Apr 11, 2025
@legendecas @JonasBa
src: disable abseil deadlock detection
43d10a1 
Abseil deadlock detection is reporting false positives in tests.
Disable it for now.

PR-URL: nodejs#57582
Refs: nodejs/node-v8#301
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Stefan Stojanovic <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
RafaelGSS pushed a commit that referenced this pull request May 1, 2025
@legendecas @RafaelGSS
src: disable abseil deadlock detection
887f4d6 
Abseil deadlock detection is reporting false positives in tests.
Disable it for now.

PR-URL: #57582
Refs: nodejs/node-v8#301
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Stefan Stojanovic <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request May 1, 2025
Merged
RafaelGSS pushed a commit that referenced this pull request May 2, 2025
@legendecas @RafaelGSS
src: disable abseil deadlock detection
a3ad331 
Abseil deadlock detection is reporting false positives in tests.
Disable it for now.

PR-URL: #57582
Refs: nodejs/node-v8#301
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Stefan Stojanovic <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
@aduh95 aduh95 added the backport-requested-v22.x PRs awaiting manual backport to the v22.x-staging branch. label May 6, 2025
@aduh95
Copy link
Contributor

aduh95 commented May 6, 2025 •
edited
Loading

This doesn't land cleanly on v22.x-staging, can you add it to #57982

@aduh95 aduh95 mentioned this pull request May 6, 2025
Open
legendecas added a commit to legendecas/node that referenced this pull request May 12, 2025
@legendecas
src: disable abseil deadlock detection
b6af552 
Abseil deadlock detection is reporting false positives in tests.
Disable it for now.

PR-URL: nodejs#57582
Refs: nodejs/node-v8#301
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Stefan Stojanovic <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
legendecas added a commit to legendecas/node that referenced this pull request May 12, 2025
@legendecas
src: disable abseil deadlock detection
ee5f46a 
Abseil deadlock detection is reporting false positives in tests.
Disable it for now.

PR-URL: nodejs#57582
Refs: nodejs/node-v8#301
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Stefan Stojanovic <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@anonrig anonrig anonrig approved these changes

@targos targos targos approved these changes

@StefanStojanovic StefanStojanovic StefanStojanovic approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

Assignees
No one assigned
Labels
backport-requested-v22.x PRs awaiting manual backport to the v22.x-staging branch. build Issues and PRs related to build files or the CI. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.