Skip to content

src: fix -Wunreachable-code-return in node_sea #57664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

src: fix -Wunreachable-code-return in node_sea #57664

wants to merge 1 commit into from
+2 −1

Conversation

codebytere
Copy link
Member

As in title - correct the following:

../../third_party/electron_node/src/node_sea.cc:641:10: error: 'return' will never be executed [-Werror,-Wunreachable-code-return]
  641 |   return false;
      |          ^~~~~
1 error generated.

@codebytere codebytere requested a review from joyeecheung March 28, 2025 14:15
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/single-executable

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. single-executable Issues and PRs related to single-executable applications labels Mar 28, 2025
@codecov Codecov

This comment was marked as outdated.

Sign in to view
@codebytere codebytere added request-ci Add this label to start a Jenkins CI on a PR. and removed needs-ci PRs that need a full CI run. labels Mar 31, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 1, 2025
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. labels Apr 1, 2025
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66369/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@dsanders11 dsanders11 dsanders11 approved these changes

@legendecas legendecas legendecas approved these changes

@aymen94 aymen94 aymen94 approved these changes

@tony-go tony-go tony-go approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

@joyeecheung joyeecheung Awaiting requested review from joyeecheung

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. single-executable Issues and PRs related to single-executable applications
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@codebytere @nodejs-github-bot @lpinca @dsanders11 @legendecas @aymen94 @tony-go @RaisinTen @aduh95