Skip to content

lib: fix default AbortController.abort() message #57735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nektro
Copy link
Contributor

@nektro nektro commented Apr 2, 2025

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Apr 2, 2025
Copy link

codecov bot commented Apr 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.24%. Comparing base (5a2614f) to head (1ab2db6).
Report is 23 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #57735      +/-   ##
==========================================
+ Coverage   90.23%   90.24%   +0.01%     
==========================================
  Files         630      630              
  Lines      185074   184982      -92     
  Branches    36221    36218       -3     
==========================================
- Hits       166994   166946      -48     
+ Misses      11036    10990      -46     
- Partials     7044     7046       +2     
Files with missing lines Coverage Δ
lib/internal/abort_controller.js 98.14% <100.00%> (ø)

... and 54 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@RaisinTen RaisinTen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but you need to update the expected error messages in the tests

@KhafraDev
Copy link
Member

KhafraDev commented Apr 3, 2025

Where does the spec dictate that the description must be the error message?

For example I'm pretty sure if we implemented URLMismatchError its message wouldn't be "Deprecated.".

@KhafraDev KhafraDev added the semver-major PRs that contain breaking changes and should be released in the next major version. label Apr 3, 2025
@nektro
Copy link
Contributor Author

nektro commented Apr 3, 2025

taking another look, https://webidl.spec.whatwg.org/#js-creating-throwing-exceptions for DOMException says message is implementation defined.

initially opened this because while investigating other code we noticed Safari, Firefox, Bun use the default description from the spec
Node's message was the default one sans only the period
Chrome's message is signal is aborted without reason
Ladybird's message is Aborted without reason
workerd's message is the default one sans only the period

@legendecas
Copy link
Member

See https://nodejs.org/api/errors.html#errorcode, error message can be changed in any versions of Node.js. I don't think this is necessarily a semver major change.

@KhafraDev
Copy link
Member

Mostly being careful because this will break things, mostly tests https://github.com/search?q=%22This+operation+was+aborted%22&type=code

nodejs-github-bot pushed a commit that referenced this pull request Apr 9, 2025
PR-URL: #57783
Refs: #57735
Reviewed-By: Jordan Harband <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jason Zhang <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
JonasBa pushed a commit to JonasBa/node that referenced this pull request Apr 11, 2025
PR-URL: nodejs#57783
Refs: nodejs#57735
Reviewed-By: Jordan Harband <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jason Zhang <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
RafaelGSS pushed a commit that referenced this pull request May 1, 2025
PR-URL: #57783
Refs: #57735
Reviewed-By: Jordan Harband <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jason Zhang <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
RafaelGSS pushed a commit that referenced this pull request May 2, 2025
PR-URL: #57783
Refs: #57735
Reviewed-By: Jordan Harband <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jason Zhang <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
aduh95 pushed a commit that referenced this pull request May 6, 2025
PR-URL: #57783
Refs: #57735
Reviewed-By: Jordan Harband <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jason Zhang <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
RafaelGSS pushed a commit that referenced this pull request May 14, 2025
PR-URL: #57783
Refs: #57735
Reviewed-By: Jordan Harband <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jason Zhang <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
aduh95 pushed a commit that referenced this pull request May 16, 2025
PR-URL: #57783
Refs: #57735
Reviewed-By: Jordan Harband <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jason Zhang <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
aduh95 pushed a commit that referenced this pull request May 17, 2025
PR-URL: #57783
Refs: #57735
Reviewed-By: Jordan Harband <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jason Zhang <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
aduh95 pushed a commit that referenced this pull request May 17, 2025
PR-URL: #57783
Refs: #57735
Reviewed-By: Jordan Harband <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jason Zhang <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
aduh95 pushed a commit that referenced this pull request May 17, 2025
PR-URL: #57783
Refs: #57735
Reviewed-By: Jordan Harband <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jason Zhang <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
aduh95 pushed a commit that referenced this pull request May 19, 2025
PR-URL: #57783
Refs: #57735
Reviewed-By: Jordan Harband <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jason Zhang <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run. semver-major PRs that contain breaking changes and should be released in the next major version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants