-
-
Notifications
You must be signed in to change notification settings - Fork 31.6k
lib: fix default AbortController.abort() message #57735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #57735 +/- ##
==========================================
+ Coverage 90.23% 90.24% +0.01%
==========================================
Files 630 630
Lines 185074 184982 -92
Branches 36221 36218 -3
==========================================
- Hits 166994 166946 -48
+ Misses 11036 10990 -46
- Partials 7044 7046 +2
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but you need to update the expected error messages in the tests
Where does the spec dictate that the description must be the error message? For example I'm pretty sure if we implemented URLMismatchError its message wouldn't be "Deprecated.". |
taking another look, https://webidl.spec.whatwg.org/#js-creating-throwing-exceptions for DOMException says message is implementation defined. initially opened this because while investigating other code we noticed Safari, Firefox, Bun use the default description from the spec |
did not previously match spec https://dom.spec.whatwg.org/#dom-abortsignal-abort https://webidl.spec.whatwg.org/#aborterror Co-authored-by: pfg <[email protected]>
See https://nodejs.org/api/errors.html#errorcode, error message can be changed in any versions of Node.js. I don't think this is necessarily a semver major change. |
Mostly being careful because this will break things, mostly tests https://github.com/search?q=%22This+operation+was+aborted%22&type=code |
PR-URL: #57783 Refs: #57735 Reviewed-By: Jordan Harband <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jason Zhang <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: nodejs#57783 Refs: nodejs#57735 Reviewed-By: Jordan Harband <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jason Zhang <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: #57783 Refs: #57735 Reviewed-By: Jordan Harband <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jason Zhang <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: #57783 Refs: #57735 Reviewed-By: Jordan Harband <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jason Zhang <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: #57783 Refs: #57735 Reviewed-By: Jordan Harband <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jason Zhang <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: #57783 Refs: #57735 Reviewed-By: Jordan Harband <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jason Zhang <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: #57783 Refs: #57735 Reviewed-By: Jordan Harband <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jason Zhang <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: #57783 Refs: #57735 Reviewed-By: Jordan Harband <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jason Zhang <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: #57783 Refs: #57735 Reviewed-By: Jordan Harband <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jason Zhang <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: #57783 Refs: #57735 Reviewed-By: Jordan Harband <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jason Zhang <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: #57783 Refs: #57735 Reviewed-By: Jordan Harband <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jason Zhang <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
did not previously match spec
https://dom.spec.whatwg.org/#dom-abortsignal-abort
https://webidl.spec.whatwg.org/#aborterror