[help wanted] deps: update V8 to 13.6

.github/workflows/tools.yml

@@ -36,7 +36,6 @@ on:
           - postject
           - root-certificates
           - simdjson
-          - simdutf
           - sqlite
           - undici
           - uvwasi
@@ -244,14 +243,6 @@ jobs:
               cat temp-output
               tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true
               rm temp-output
-          - id: simdutf
-            subsystem: deps
-            label: dependencies
-            run: |
-              ./tools/dep_updaters/update-simdutf.sh > temp-output
-              cat temp-output
-              tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true
-              rm temp-output
           - id: sqlite
             subsystem: deps
             label: dependencies, sqlite

LICENSE

@@ -1489,7 +1489,7 @@ The externally maintained libraries used by Node.js are:
         This code is copyrighted by Sun Microsystems Inc. and released
         under a 3-clause BSD license.
 
-      - Valgrind client API header, located at src/third_party/valgrind/valgrind.h
+      - Valgrind client API header, located at third_party/valgrind/valgrind.h
         This is released under the BSD license.
 
       - The Wasm C/C++ API headers, located at third_party/wasm-api/wasm.{h,hh}
@@ -1774,7 +1774,7 @@ The externally maintained libraries used by Node.js are:
        limitations under the License.
   """
 
-- simdutf, located at deps/simdutf, is licensed as follows:
+- simdutf, located at deps/v8/third_party/simdutf, is licensed as follows:
   """
     Copyright 2021 The simdutf authors
 

Makefile

@@ -654,10 +654,6 @@ test-internet: all ## Run internet tests.
 test-tick-processor: all ## Run tick processor tests.
 	$(PYTHON) tools/test.py $(PARALLEL_ARGS) tick-processor
 
-.PHONY: test-hash-seed
-test-hash-seed: all ## Verifu that the hash seed used by V8 for hashing is random.
-	$(NODE) test/pummel/test-hash-seed.js
-
 .PHONY: test-doc
 test-doc: doc-only lint-md ## Build, lint, and verify the docs.
 	@if [ "$(shell $(node_use_openssl_and_icu))" != "true" ]; then \
@@ -751,8 +747,6 @@ test-v8: v8  ## Run the V8 test suite on deps/v8.
 				mjsunit cctest debugger inspector message preparser \
 				$(TAP_V8)
 	$(call convert_to_junit,$(TAP_V8_JSON))
-	$(info Testing hash seed)
-	$(MAKE) test-hash-seed
 
 test-v8-intl: v8 ## Run the v8 test suite, intl tests.
 	export PATH="$(NO_BIN_OVERRIDE_PATH)" && \
@@ -768,7 +762,7 @@ test-v8-benchmarks: v8 ## Run the v8 test suite, benchmarks.
 				$(TAP_V8_BENCHMARKS)
 	$(call convert_to_junit,$(TAP_V8_BENCHMARKS_JSON))
 
-test-v8-updates: ## Run the v8 test suite, updates.
+test-v8-updates: all ## Run the v8 test suite, updates.
 	$(PYTHON) tools/test.py $(PARALLEL_ARGS) --mode=$(BUILDTYPE_LOWER) v8-updates
 
 test-v8-all: test-v8 test-v8-intl test-v8-benchmarks test-v8-updates ## Run the entire V8 test suite, including intl, benchmarks, and updates.
@@ -949,9 +943,6 @@ else
 ifeq ($(findstring s390x,$(UNAME_M)),s390x)
 DESTCPU ?= s390x
 else
-ifeq ($(findstring s390,$(UNAME_M)),s390)
-DESTCPU ?= s390
-else
 ifeq ($(findstring OS/390,$(shell uname -s)),OS/390)
 DESTCPU ?= s390x
 else
@@ -985,7 +976,6 @@ endif
 endif
 endif
 endif
-endif
 ifeq ($(DESTCPU),x64)
 ARCH=x64
 else
@@ -998,9 +988,6 @@ else
 ifeq ($(DESTCPU),ppc64)
 ARCH=ppc64
 else
-ifeq ($(DESTCPU),s390)
-ARCH=s390
-else
 ifeq ($(DESTCPU),s390x)
 ARCH=s390x
 else
@@ -1018,7 +1005,6 @@ endif
 endif
 endif
 endif
-endif
 
 # node and v8 use different arch names (e.g. node 'x86' vs v8 'ia32').
 # pass the proper v8 arch name to $V8_ARCH based on user-specified $DESTCPU.

benchmark/napi/function_args/binding.cc

@@ -21,7 +21,7 @@ void CallWithString(const FunctionCallbackInfo<Value>& args) {
   assert(args.Length() == 1 && args[0]->IsString());
   if (args.Length() == 1 && args[0]->IsString()) {
     Local<String> str = args[0].As<String>();
-    const int32_t length = str->Utf8Length(args.GetIsolate()) + 1;
+    const size_t length = str->Utf8LengthV2(args.GetIsolate()) + 1;
     char* buf = new char[length];
     str->WriteUtf8(args.GetIsolate(), buf, length);
     delete[] buf;

common.gypi

@@ -38,7 +38,7 @@
 
     # Reset this number to 0 on major V8 upgrades.
     # Increment by one for each non-official patch applied to deps/v8.
-    'v8_embedder_string': '-node.12',
+    'v8_embedder_string': '-node.10',
 
     ##### V8 defaults for Node.js #####
 
@@ -568,6 +568,7 @@
           }],
           [ 'node_shared=="true"', {
             'cflags': [ '-fPIC' ],
+            'ldflags': [ '-fPIC' ],
           }],
         ],
       }],

configure.py

@@ -640,12 +640,6 @@
     default=None,
     help='[Experimental] Enable V8 pointer compression (limits max heap to 4GB and breaks ABI compatibility)')
 
-parser.add_argument('--disable-shared-readonly-heap',
-    action='store_true',
-    dest='disable_shared_ro_heap',
-    default=None,
-    help='Disable the shared read-only heap feature in V8')
-
 parser.add_argument('--v8-options',
     action='store',
     dest='v8_options',
@@ -1720,7 +1714,6 @@ def configure_v8(o, configs):
   o['variables']['v8_enable_pointer_compression'] = 1 if options.enable_pointer_compression else 0
   o['variables']['v8_enable_sandbox'] = 1 if options.enable_pointer_compression else 0
   o['variables']['v8_enable_31bit_smis_on_64bit_arch'] = 1 if options.enable_pointer_compression else 0
-  o['variables']['v8_enable_shared_ro_heap'] = 0 if options.enable_pointer_compression or options.disable_shared_ro_heap else 1
   o['variables']['v8_enable_extensible_ro_snapshot'] = 0
   o['variables']['v8_trace_maps'] = 1 if options.trace_maps else 0
   o['variables']['node_use_v8_platform'] = b(not options.without_v8_platform)

deps/v8/.bazelrc

@@ -2,10 +2,14 @@
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
+# Enable Bzlmod for every Bazel command
+common --enable_bzlmod
+
 # Pass CC, CXX and PATH from the environment
 build --action_env=CC
 build --action_env=CXX
 build --action_env=PATH
+build --copt=-std=c++20
 
 # Use Clang compiler
 build:clang --action_env=BAZEL_COMPILER=clang
@@ -17,7 +21,8 @@ build:debug --compilation_mode=dbg
 build:debug --config=v8_enable_debugging_features
 build:debug --//:v8_enable_fast_mksnapshot
 build:debug --//:v8_enable_backtrace
-build:debug --//:v8_enable_handle_zapping
+build:debug --//:v8_enable_local_handle_zapping
+build:debug --//:v8_enable_global_handle_zapping
 
 # v8_enable_debugging_features flags
 build:v8_enable_debugging_features --//:v8_enable_verify_heap

deps/v8/.clang-tidy

@@ -9,7 +9,9 @@
                     modernize-redundant-void-arg,
                     modernize-replace-random-shuffle,
                     modernize-shrink-to-fit,
+                    modernize-type-traits,
                     # modernize-use-auto,
+                    modernize-use-constraints,
                     modernize-use-bool-literals,
                     modernize-use-equals-default,
                     # modernize-use-equals-delete,

deps/v8/.gitignore

@@ -82,14 +82,21 @@
 /third_party/googletest/src/googletest/include/gtest/*
 !/third_party/googletest/src/googletest/include/gtest/gtest_prod.h
 !/third_party/highway
-/third_party/highway/src
+/third_party/highway/src/*
+!/third_party/highway/src/hwy
 !/third_party/inspector_protocol
 !/third_party/jsoncpp
 /third_party/jsoncpp/source
+!/third_party/llvm-libc
+/third_party/llvm-libc/src
+!/third_party/rapidhash-v8
 !/third_party/re2
 /third_party/re2/src
-!/third_party/test262-harness
+!/third_party/siphash
+!/third_party/utf8-decoder
 !/third_party/v8
+!/third_party/valgrind
+!/third_party/vtune
 !/third_party/wasm-api
 /tools/builtins-pgo/profiles/*
 !/tools/builtins-pgo/profiles/.*
@@ -103,6 +110,7 @@
 /tools/oom_dump/oom_dump
 /tools/oom_dump/oom_dump.o
 /tools/protoc_wrapper
+/tools/rust
 /tools/turbolizer/build
 /tools/turbolizer/.rpt2_cache
 /tools/turbolizer/deploy
@@ -145,3 +153,4 @@ bazel-v8
 !/third_party/fp16
 /third_party/fp16/src/*
 !/third_party/fp16/src/include
+!/third_party/simdutf

deps/v8/.gn

@@ -27,8 +27,9 @@ no_check_targets = [
 default_args = {
   # Disable js dependencies like the closure compiler.
   enable_js_protobuf = false
+
   # Disable rust dependencies.
-  enable_rust = false
+  enable_rust = true
 }
 
 # These are the list of GN files that run exec_script. This whitelist exists

deps/v8/AUTHORS

@@ -57,8 +57,9 @@ Alexander Botero-Lowry <[email protected]>
 Alexander Karpinsky <[email protected]>
 Alexander Neville <[email protected]>
 Alexandre Vassalotti <[email protected]>
-Alexey Pavlyutkin <alexey.pavlyutkin.community@gmail.com>
+Alexey Pavlyutkin <alexey.pavlyutkin@syntacore.com>
 Alexis Campailla <[email protected]>
+Aliya Minimullina <[email protected]>
 Allan Sandfeld Jensen <[email protected]>
 Amos Lim <[email protected]>
 Andreas Anyuru <[email protected]>
@@ -120,6 +121,7 @@ Dominic Farolini <[email protected]>
 Douglas Crosher <[email protected]>
 Dusan Milosavljevic <[email protected]>
 Eden Wang <[email protected]>
+Edoardo Marangoni <[email protected]>
 Elisha Hollander <[email protected]>
 Eric Rannaud <[email protected]>
 Erich Ocean <[email protected]>
@@ -210,11 +212,13 @@ Maxim Mazurok <[email protected]>
 Maxim Mossienko <[email protected]>
 Md Hasibul Hasan <[email protected]>
 Meir Shpilraien <[email protected]>
+Meng Tan <[email protected]>
 Michael Lutz <[email protected]>
 Michael Mclaughlin <[email protected]>
 Michael Smith <[email protected]>
 Michaël Zasso <[email protected]>
 Mihir Shah <[email protected]>
+Mika Fischer <[email protected]>
 Mike Gilbert <[email protected]>
 Mike Pennisi <[email protected]>
 Mikhail Gusarov <[email protected]>
@@ -268,6 +272,7 @@ Sébastien Doeraene <[email protected]>
 Seo Sanghyeon <[email protected]>
 Shawn Anastasio <[email protected]>
 Shawn Presser <[email protected]>
+Sho Miyamoto <[email protected]>
 Stefan Penner <[email protected]>
 Stefan Stojanovic <[email protected]>
 Stephan Hartmann <[email protected]>
@@ -290,6 +295,7 @@ Varun Varada <[email protected]>
 Victor Costan <[email protected]>
 Victor Polevoy <[email protected]>
 Vlad Burlik <[email protected]>
+Vladimir Kempik <[email protected]>
 Vladimir Krivosheev <[email protected]>
 Vladimir Shutoff <[email protected]>
 Wael Almattar <[email protected]>
@@ -303,6 +309,7 @@ Wiktor Garbacz <[email protected]>
 Wouter Vermeiren <[email protected]>
 Xiaofang Zou <[email protected]>
 Xiaoyin Liu <[email protected]>
+Yagiz Nizipli <[email protected]>
 Yanbo Li <[email protected]>
 Yannic Bonenberger <[email protected]>
 Yi Wang <[email protected]>
@@ -317,6 +324,7 @@ Yuxiang Cao <[email protected]>
 Zac Hansen <[email protected]>
 Zeynep Cankara <[email protected]>
 Zhao Jiazhong <[email protected]>
+Zhao Qin <[email protected]>
 Zhaojun Meng <[email protected]>
 Zheng Liu <[email protected]>
 Zhongping Wang <[email protected]>
@@ -325,3 +333,4 @@ Yang Xiang <[email protected]>
 Kotaro Ohsugi <[email protected]>
 Jing Peiyang <[email protected]>
 magic-akari <[email protected]>
+Ryuhei Shima <[email protected]>