test: migrate snapshots from python to js #57778
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
bjohansebas
commented
Apr 7, 2025
| *[90m ... 6 lines matching cause stack trace ...*[39m | ||
| *[90m at *[39m { | ||
| [cause]: FoobarError: Individual message | ||
| at Object.<anonymous> \x1B[90m(/\x1B[39mtest*util_inspect_error_cause.js:*:*\x1B[90m)\x1B[39m { |
There was a problem hiding this comment.
For some reason, \x1B gets transformed into \\x1B in the snapshot output, and as a result the input ends up being different, but only in this test. It's a bit of strange behavior, does anyone have any idea? It doesn't seem to be related to this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There’s still one test failing related to this PR, but with this PR we should have migrated all the tests in
/test/messageto use Node.js' built-in snapshotsref #47707