doc: increase z-index of header element #57851
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
increase the z-index of the header element to make sure that opened pickers from it (such as the node version picker) are on top of other content
|
Review requested:
|
bjohansebas
approved these changes
Apr 12, 2025
lpinca
approved these changes
Apr 12, 2025
avivkeller
approved these changes
Apr 12, 2025
bjohansebas
added
the
author ready
AugustinMauroy
approved these changes
Apr 12, 2025
|
BTW this change have to be "backport" to |
Sorry @AugustinMauroy I'm not sure what that means, could you clarify? 🙏 is this something I need to do? |
aduh95
added
lts-watch-v18.x
lts-watch-v20.x
aduh95
approved these changes
Apr 12, 2025
This change might be lost since we’re migrating to another package that is being created for documentation generation in api-docs-tooling (see #57343), so you need to make that change in api-docs-tooling as well https://github.com/nodejs/api-docs-tooling/blob/main/src/generators/legacy-html/assets/style.css |
|
No need to backport. The change that introduced this issue hasn't been backported yet. |
Co-authored-by: Antoine du Hamel <[email protected]>
ah I see, ok thanks a lot for the extra context here 🫶
But it sounds like that might not be needed anyways 🙂 |
aymen94
approved these changes
Apr 14, 2025
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/57851 ✔ Done loading data for nodejs/node/pull/57851 ----------------------------------- PR info ------------------------------------ Title doc: increase z-index of header element (#57851) Author Dario Piotrowicz <[email protected]> (@dario-piotrowicz) Branch dario-piotrowicz:dario/docs-header-z-index-fix -> nodejs:main Labels doc, author ready, lts-watch-v18.x, lts-watch-v20.x Commits 3 - doc: increase z-index of header element - remove unnecessary z-index - Update doc/api_assets/style.css Committers 2 - Dario Piotrowicz <[email protected]> - GitHub <[email protected]> PR-URL: https://github.com/nodejs/node/pull/57851 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/57851 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - doc: increase z-index of header element ⚠ - remove unnecessary z-index ⚠ - Update doc/api_assets/style.css ℹ This PR was created on Sat, 12 Apr 2025 18:26:15 GMT ✔ Approvals: 2 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/57851#pullrequestreview-2762237409 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/57851#pullrequestreview-2762265947 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/14453190816 |
jasnell
approved these changes
Apr 14, 2025
jasnell
pushed a commit
that referenced
this pull request
Apr 14, 2025
increase the z-index of the header element to make sure that opened pickers from it (such as the node version picker) are on top of other content PR-URL: #57851 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
|
Landed in 11bb7cd |
RafaelGSS
pushed a commit
that referenced
this pull request
May 1, 2025
increase the z-index of the header element to make sure that opened pickers from it (such as the node version picker) are on top of other content PR-URL: #57851 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
RafaelGSS
pushed a commit
that referenced
this pull request
May 2, 2025
increase the z-index of the header element to make sure that opened pickers from it (such as the node version picker) are on top of other content PR-URL: #57851 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
May 6, 2025
increase the z-index of the header element to make sure that opened pickers from it (such as the node version picker) are on top of other content PR-URL: #57851 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
May 6, 2025
increase the z-index of the header element to make sure that opened pickers from it (such as the node version picker) are on top of other content PR-URL: #57851 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
RafaelGSS
pushed a commit
that referenced
this pull request
May 14, 2025
increase the z-index of the header element to make sure that opened pickers from it (such as the node version picker) are on top of other content PR-URL: #57851 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
increase the z-index of the header element to make sure that opened pickers from it (such as the node verion picker) are on top of other content
This is addressing a minor issue I just noticed when reading the docs, the header pickers can be covered by api stability banners, for example go to https://nodejs.org/docs/latest/api/repl.html open the nodejs versions picker and while the picker is open scroll down till the REPL section and you should see the following:
with my change the picker remains on top: