-
-
Notifications
You must be signed in to change notification settings - Fork 31.6k
test_runner: emit test:watch:restarted event on watched file changes #57903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Review requested:
|
Hey @JacopoPatroclo, thanks for the PR. Could you please add tests to cover the new behaviour? Also, could you please update the documentation? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #57903 +/- ##
==========================================
+ Coverage 90.26% 90.28% +0.01%
==========================================
Files 630 630
Lines 185933 186331 +398
Branches 36447 36508 +61
==========================================
+ Hits 167840 168233 +393
- Misses 10971 10976 +5
Partials 7122 7122
🚀 New features to boost your workflow:
|
one small nit - the
commit-queue-squash
|
@jakecastelli thanks for pointing it out!!! there's no rush, I'd say we could just ask @JacopoPatroclo to manually rewrite the history! |
Ahh no worries at all! Happy to do another approval / CI once the commit message is fixed 👍 |
The goal of this PR is to add a
test:watch:restarted
event to signal to the reporter that some tests have restarted while in watch mode.This will enable a trivial fix for nodejs/node#57206, which I plan to address later.