-
-
Notifications
You must be signed in to change notification settings - Fork 31.6k
util: update util.isArray() to eol #58027
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
It seems like there is still some hesitation about doing this - #58013 (comment). |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58027 +/- ##
==========================================
+ Coverage 90.18% 90.20% +0.02%
==========================================
Files 631 633 +2
Lines 186693 186831 +138
Branches 36665 36675 +10
==========================================
+ Hits 168378 168540 +162
+ Misses 11121 11081 -40
- Partials 7194 7210 +16
🚀 New features to boost your workflow:
|
I think build is failing because a link to the |
Failed to start CI⚠ Commits were pushed since the last approving review: ⚠ - util: update util.isArray() to eol ⚠ - Update version change with pr number ⚠ - fix endoflife typo ⚠ - Fix typo from version ⚠ - doc: update deprecation notice for util.isArray() removal ⚠ - doc: remove unused reference to Array.isArray() in util documentation ✘ Refusing to run CI on potentially unsafe PRhttps://github.com/nodejs/node/actions/runs/14686825918 |
d29f97e
to
d819523
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still encounter this API in the wild a fair amount. I'm not all that convinced we should move this one of EOL just yet.
Refs #58013
Update
util.isArray
to eol