-
-
Notifications
You must be signed in to change notification settings - Fork 31.6k
buffer: add fast api for isAscii & isUtf8 #58058
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
6bb4020
to
8432a57
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #58058 +/- ##
==========================================
- Coverage 90.17% 90.16% -0.02%
==========================================
Files 630 630
Lines 186473 186496 +23
Branches 36613 36614 +1
==========================================
+ Hits 168160 168162 +2
- Misses 11128 11132 +4
- Partials 7185 7202 +17
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work.
2841143
to
ab8d328
Compare
ab8d328
to
d7ffbed
Compare
d7ffbed
to
54410b2
Compare
54410b2
to
7e84063
Compare
@jasnell @Renegade334 can you review this pull-request one more time? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be worth re-running benchmarks, but LGTM 👍
(Needs dont-land-on-v20.x/v22.x, as the old fast API did not provide access to the isolate.)
Adds v8 fast api for IsUtf8 and IsAscii methods
isAscii benchmark: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1706/
isUtf8 benchmark: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1708/