-
-
Notifications
You must be signed in to change notification settings - Fork 31.6k
doc: add instructions about using Visual Studio #58094
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Did you try |
I tried running with |
cc @nodejs/platform-windows @nodejs/build |
I tested on my machine. I was using the latest main, so ClangCL was forced, but I can rerun it with the v23 branch (or a bit older main) to see if MSVC makes any difference. Here is what I found:
On another note, when I run the build for the second time (regardless of
|
I am not sure why but locally using
vcbuild.bat
never gives me real incremental builds - I am on a fairly old laptop, runningvcbuild.bat
again on an already built project would still try to rebuild the binary and take ~15min to finish even if I do not change the source code at all (IIRC this was also the case ~5 years ago when I still used Windows for a while). It also floods the shell with warnings and buries any compilation errors in the warnings. On the other hand when I loadnode.sln
into Visual Studio I am able to have better incremental build (if I do not change anything it takes <1min for it to finish the process. If I only touch some .cc files it also only takes around 1min to finish building) and the warnings are minimal, allowing me to actually see compilation errors. So I think it's worth mentioning how to use Visual Studio for people developing on Windows.