http2: add lenient flag for RFC-9113 #58116
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
c++
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #58116 +/- ##
==========================================
+ Coverage 89.67% 90.23% +0.55%
==========================================
Files 630 633 +3
Lines 186445 186831 +386
Branches 36310 36681 +371
==========================================
+ Hits 167190 168578 +1388
+ Misses 11998 11038 -960
+ Partials 7257 7215 -42
🚀 New features to boost your workflow:
|
pimterry
requested changes
May 6, 2025
pimterry
approved these changes
May 13, 2025
| @@ -25,7 +25,8 @@ const IDX_OPTIONS_MAX_SESSION_MEMORY = 8; | |||
| const IDX_OPTIONS_MAX_SETTINGS = 9; | |||
| const IDX_OPTIONS_STREAM_RESET_RATE = 10; | |||
| const IDX_OPTIONS_STREAM_RESET_BURST = 11; | |||
| const IDX_OPTIONS_FLAGS = 12; | |||
| const IDX_OPTIONS_STRICT_HTTP_HEADER_FIELD_VALIDATION = 12; | |||
There was a problem hiding this comment.
Nit: this still has the old option name (just test code, but nice to be consistent)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aims to close #56703.
The PR proposes the addition of a new flag (provisionally named
strictHttpFieldValidation) to be added while creating an HTTP/2 session (either client or server side).The flag maps to
nghttp2_option_set_no_rfc9113_leading_and_trailing_ws_validationto disable the trailing white space trimming as per RFC-9113.The flag is not mapped by default to be backwards compatible.
Looking forward for feedback before actually kick-off addition of documentation.