Skip to content

test: make crypto tests work with BoringSSL #58117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test: make crypto tests work with BoringSSL #58117

wants to merge 1 commit into from

Conversation

codebytere
Copy link
Member

As in title - this PR makes crypto tests work with BoringSSL. Similar to previous PRs.

@codebytere codebytere requested a review from jasnell May 2, 2025 10:15
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels May 2, 2025
@codecov Codecov
Copy link

codecov bot commented May 2, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.21%. Comparing base (2b4f554) to head (342e096).
Report is 46 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #58117      +/-   ##
==========================================
+ Coverage   90.20%   90.21%   +0.01%     
==========================================
  Files         630      630              
  Lines      186446   186446              
  Branches    36619    36618       -1     
==========================================
+ Hits       168190   168210      +20     
+ Misses      11053    11043      -10     
+ Partials     7203     7193      -10

see 33 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label May 2, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 2, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66543/

@codebytere codebytere mentioned this pull request May 2, 2025
Merged
mhdawson
mhdawson approved these changes May 2, 2025
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@mhdawson mhdawson mhdawson approved these changes

Assignees
No one assigned
Labels
needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@codebytere @nodejs-github-bot @jasnell @lpinca @mhdawson