-
-
Notifications
You must be signed in to change notification settings - Fork 31.6k
doc: clarify --watch and --watch-path usage with --run #58136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Hi! Thanks for taking care of this. The PR may need some extra edits. The implies of watch in watch-path is not being shown, and also, just keep in mind that the --run flag has priority; It can not be mixed with watch and its derivatives. Could you please reflect that into your PR? Refs: |
Hi @juanarbol!, thanks for the observation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some more minor clarifications, I'm sorry I just forgot a couple details, but after this; I'm more than happy with this PR. Thanks again!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RLGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Test failure is already reported. Refs: #58127 |
a0fca22
to
b740f44
Compare
Updated the first commit message accordingly by amending it |
Thanks. You don't have to do it now, but if you intend to land a single commit, squash everything into a single commit. |
90561a2
to
c5881e6
Compare
Thanks! I've squashed the commits and the PR should be ready now. Let me know if there's anything else needed from my side. |
I'm sorry, CI still not happy due to commit guidelines. Fix it, will approve and wait for more reviews :-) Humble ping to @nodejs/documentation Refs: |
c5881e6
to
e8bef23
Compare
Yeah, missed that part 🙏. |
Co-authored-by: Tierney Cyren <[email protected]>
This PR adds a note under the
--watch
and--watch-path
CLI options incli.md
to clarify that these flags require a file path and cannot be used with--run
.Fixes confusion where users might assume
--watch-path
or--watch
work with--run
, which currently results in a runtime error.Helps address issue discussion here