fs: improve cpSync dest overriding performance

[dario-piotrowicz]

move the logic in cpSync that overrides existing dest files from JavaScript to C++ increasing its performance

---

This is the type of perf improvement that this change makes:

[anonrig]

Your benchmark needs options.force in order to trigger the path you're updating, isn't it? Or do you have force: true as the default value.

[dario-piotrowicz]

Your benchmark needs options.force in order to trigger the path you're updating, isn't it? Or do you have force: true as the default value.

Yes, force: true is the default 🙂

[codecov]

Codecov Report

Attention: Patch coverage is 31.37255% with 35 lines in your changes missing coverage. Please review.

Project coverage is 90.19%. Comparing base (cfd2021) to head (aa6904c).
Report is 27 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_file.cc	27.90%	20 Missing and 11 partials ⚠️
src/env-inl.h	0.00%	4 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##             main   #58160    +/-   ##
========================================
  Coverage   90.18%   90.19%            
========================================
  Files         631      633     +2     
  Lines      186693   186880   +187     
  Branches    36665    36690    +25     
========================================
+ Hits       168378   168563   +185     
+ Misses      11121    11097    -24     
- Partials     7194     7220    +26     

Files with missing lines	Coverage Δ
lib/internal/fs/cp/cp-sync.js	92.13% <100.00%> (-0.11%)	⬇️
src/env.h	98.14% <ø> (ø)
src/env-inl.h	93.39% <0.00%> (-0.81%)	⬇️
src/node_file.cc	76.07% <27.90%> (-0.87%)	⬇️

... and 34 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[dario-piotrowicz]

Could we get another benchmark that only removed existing files? I guess it will also be faster, it is just helpful to know by how much.

Sorry could you clarify what you mean? 🙏

This code, as far as my understanding goes, is only effecting cpSync when it is overriding the destination file, no other cp operation should see any difference here 🤔

[BridgeAR]

You are absolutely correct! I misread. Please ignore my comment :)

[dario-piotrowicz]

Ah ok no worries 😄👍

[anonrig]

Windows error

src\node_file.cc(40,10): fatal  error : 'utime.h' file not found [D:\a\node\node\libnode.vcxproj]

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/66807/