node-api: use WriteV2 in napi_get_value_string_utf16 #58165
+10
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tniessen
added
c++
|
Review requested:
|
juanarbol
approved these changes
May 4, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58165 +/- ##
==========================================
+ Coverage 90.17% 90.23% +0.05%
==========================================
Files 630 633 +3
Lines 186503 186807 +304
Branches 36614 36665 +51
==========================================
+ Hits 168187 168565 +378
+ Misses 11124 11041 -83
- Partials 7192 7201 +9
🚀 New features to boost your workflow:
|
|
Could you also replace the other deprecated |
vmoroz
reviewed
May 4, 2025
vmoroz
reviewed
May 4, 2025
vmoroz
reviewed
May 4, 2025
jasnell
approved these changes
May 7, 2025
Since `String::Write()` is deprecated, use `String::Write2()` instead. That requires us to compute the correct number of characters ahead of time but removes the need for dealing with the return value.
tniessen
force-pushed
the
napi_get_value_string_utf16-writev2
branch
from
86f6bee to
da6a60e
Compare
legendecas
approved these changes
May 14, 2025
github-actions
bot
removed
the
request-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
String::Write()is deprecated, useString::Write2()instead. That requires us to compute the correct number of characters ahead of time but removes the need for dealing with the return value.