tools: make use of modern syntax in tools/install.py
#58167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
build
aduh95
added
dont-land-on-v20.x
richardlau
previously requested changes
May 6, 2025
Shouldn't it be the other way around? If there's a reason not to do this, you should be the one letting us know given you're the one suggesting the change. It's a very large change hard to review, and it's unclear what we get out of it. |
|
I've simplified. To clarify, my goal was to make this use pathlib, f-strings, a similar. |
jasnell
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From my perspective, this file relies on a few outdated practices:
pathlibIf there is a reason for these outdated practices, feel free to let me know :-)