Skip to content

test: force slow JSON.stringify path for overflow #58181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

codebytere
Copy link
Member

Refs https://chromium-review.googlesource.com/c/v8/v8/+/6011806

The V8 team just enabled the JSON.stringify fast path by default, which is iterative and won't throw. Pre-emptively preserve test functionality by forcing the slow path. See above linked PR for approach this is borrowed from.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels May 5, 2025
@codebytere codebytere force-pushed the force-stringify-slow branch from c9a052a to 858d4dd Compare May 5, 2025 13:02
@codebytere codebytere force-pushed the force-stringify-slow branch from 858d4dd to b6f1e82 Compare May 5, 2025 13:03
Copy link

codecov bot commented May 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.15%. Comparing base (f75a126) to head (b6f1e82).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #58181      +/-   ##
==========================================
- Coverage   90.17%   90.15%   -0.02%     
==========================================
  Files         630      630              
  Lines      186756   186756              
  Branches    36664    36652      -12     
==========================================
- Hits       168399   168375      -24     
- Misses      11179    11189      +10     
- Partials     7178     7192      +14     

see 39 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels May 6, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 6, 2025
@nodejs-github-bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants