inspector: add mimeType and charset support to Network.Response #58192
Conversation
nodejs-github-bot
added
c++
| common.mustCall(({ params }) => { | ||
| assert.strictEqual(params.response.mimeType, ''); | ||
| assert.strictEqual(params.response.charset, ''); | ||
| }) |
There was a problem hiding this comment.
When the Content-Type header is not set, Chromium also assigns an empty string.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #58192 +/- ##
==========================================
+ Coverage 90.15% 90.21% +0.06%
==========================================
Files 630 633 +3
Lines 186756 186878 +122
Branches 36652 36685 +33
==========================================
+ Hits 168361 168599 +238
+ Misses 11192 11065 -127
- Partials 7203 7214 +11
🚀 New features to boost your workflow:
|
| const contentType = contentTypeKeyIndex !== -1 ? response.headers[contentTypeKeyIndex + 1].toString() : ''; | ||
| const mimeTypeObj = new MIMEType(contentType); | ||
| mimeType = mimeTypeObj.essence || ''; | ||
| charset = mimeTypeObj.params.get('charset'); |
There was a problem hiding this comment.
Charset can be undefined/null if this does not exist. I don't think we want that.
There was a problem hiding this comment.
I overlooked this case.
Like mimeType, I’ve set it to an empty string.
| }) | ||
| ); | ||
| }), | ||
| 2 |
There was a problem hiding this comment.
This seems indented out of order.
There was a problem hiding this comment.
Not sure why, but when I add a line break, eslint complains about the indent.
For now, I’ve just passed the second argument without breaking it into a new line.
Refs: #53946
It supports the mimeType and charset defined in Network.Response.
https://chromedevtools.github.io/devtools-protocol/tot/Network/#type-Response