perf_hooks: couple of perf hooks improvements #58209
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
c++
This comment was marked as outdated.
This comment was marked as outdated.
anonrig
reviewed
May 7, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58209 +/- ##
=======================================
Coverage 90.20% 90.20%
=======================================
Files 633 633
Lines 186852 186861 +9
Branches 36679 36687 +8
=======================================
+ Hits 168547 168557 +10
+ Misses 11095 11094 -1
Partials 7210 7210
🚀 New features to boost your workflow:
|
jasnell
force-pushed
the
jasnell/perf_hooks_fast_apis
branch
from
a17ab54 to
8c33455
Compare
This comment was marked as outdated.
This comment was marked as outdated.
BridgeAR
reviewed
May 7, 2025
Qard
approved these changes
May 8, 2025
jasnell
force-pushed
the
jasnell/perf_hooks_fast_apis
branch
from
8c33455 to
6157497
Compare
``` perf_hooks/bench-eventlooputil.js method='ELU_passed' n=1000000 1.18 % ±2.02% ±2.69% ±3.50% perf_hooks/bench-eventlooputil.js method='ELU_simple' n=1000000 *** 7.29 % ±1.84% ±2.45% ±3.19% perf_hooks/bench-eventlooputil.js method='idleTime' n=1000000 ** 4.20 % ±2.97% ±3.96% ±5.15% ```
jasnell
force-pushed
the
jasnell/perf_hooks_fast_apis
branch
from
6157497 to
2c6a37e
Compare
jasnell
added
the
author ready
anonrig
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uvMetricsInfoto the json output forPerformanceNodeTiming... just looks like this was overlooked