-
-
Notifications
You must be signed in to change notification settings - Fork 31.6k
build,win: fix dll build #58235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
build,win: fix dll build #58235
Conversation
Review requested:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58235 +/- ##
==========================================
+ Coverage 90.14% 90.18% +0.04%
==========================================
Files 629 629
Lines 186634 186660 +26
Branches 36616 36658 +42
==========================================
+ Hits 168236 168347 +111
+ Misses 11204 11119 -85
Partials 7194 7194
🚀 New features to boost your workflow:
|
Note that linter is failing /cc @nodejs/platform-windows |
4ef6072
to
78225e7
Compare
Failed to start CI⚠ No approving reviews found ✘ Refusing to run CI on potentially unsafe PRhttps://github.com/nodejs/node/actions/runs/14928236826 |
I think a more correct solution is to avoid inlining this in the class body? Lines 130 to 132 in e74e065
Otherwise, |
Fixes a linker error when building Node.js with ClangCL due to missing explicit template instantiation for
ThreadsafeCopyOnWrite<std::map<std::string, UnionBytes>>
.Fixes: #58208