Skip to content

build,win: fix dll build #58235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

StefanStojanovic
Copy link
Contributor

Fixes a linker error when building Node.js with ClangCL due to missing explicit template instantiation for ThreadsafeCopyOnWrite<std::map<std::string, UnionBytes>>.

Fixes: #58208

@StefanStojanovic StefanStojanovic added the windows Issues and PRs related to the Windows platform. label May 8, 2025
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/startup

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels May 8, 2025
Copy link

codecov bot commented May 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.18%. Comparing base (e38ce27) to head (78225e7).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #58235      +/-   ##
==========================================
+ Coverage   90.14%   90.18%   +0.04%     
==========================================
  Files         629      629              
  Lines      186634   186660      +26     
  Branches    36616    36658      +42     
==========================================
+ Hits       168236   168347     +111     
+ Misses      11204    11119      -85     
  Partials     7194     7194              
Files with missing lines Coverage Δ
src/node_builtins.cc 79.17% <ø> (-0.25%) ⬇️

... and 50 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aduh95
Copy link
Contributor

aduh95 commented May 8, 2025

Note that linter is failing

/cc @nodejs/platform-windows

@StefanStojanovic StefanStojanovic added the request-ci Add this label to start a Jenkins CI on a PR. label May 9, 2025
@github-actions github-actions bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels May 9, 2025
Copy link
Contributor

github-actions bot commented May 9, 2025

Failed to start CI
   ⚠  No approving reviews found
   ✘  Refusing to run CI on potentially unsafe PR
https://github.com/nodejs/node/actions/runs/14928236826

@joyeecheung
Copy link
Member

I think a more correct solution is to avoid inlining this in the class body?

node/src/node_builtins.h

Lines 130 to 132 in e74e065

[[nodiscard]] auto GetBuiltinIds() const {
return std::views::keys(*source_.read());
}

Otherwise, node_builtins.h needs to include node_threadsafe_cow-inl.h to have the implementation of the read method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot build libnode v24.0.0 on Windows
4 participants