Skip to content

tools: lint typescript files #58256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

Jorgee97
Copy link

closes #55702 by adding typescript-eslint to the linting rules.

Thanks to @avivkeller for this closed PR #55709.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/performance
  • @nodejs/typescript

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. typings labels May 10, 2025
@avivkeller
Copy link
Member

Hiya! I contributed part of this change, so I'd love if you could add me as a Co-Author.

Thanks!

@Jorgee97
Copy link
Author

Hiya! I contributed part of this change, so I'd love if you could add me as a Co-Author.

Thanks!

Sorry for not doing that before, TIL about co-authoring commits.

Copy link

codecov bot commented May 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.18%. Comparing base (4454d09) to head (375ef97).
Report is 29 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #58256      +/-   ##
==========================================
+ Coverage   90.12%   90.18%   +0.05%     
==========================================
  Files         629      629              
  Lines      186628   186641      +13     
  Branches    36622    36651      +29     
==========================================
+ Hits       168206   168324     +118     
+ Misses      11216    11110     -106     
- Partials     7206     7207       +1     

see 41 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@marco-ippolito marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label May 10, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 10, 2025
@nodejs-github-bot
Copy link
Collaborator

@JakobJingleheimer
Copy link
Member

Hiya! I contributed part of this change, so I'd love if you could add me as a Co-Author.
Thanks!

Sorry for not doing that before, TIL about co-authoring commits.

I think in order for co-authorship to work in this repo, you must add the co-author to the first commit (it's currently applied to an intermediary commit, which will get flattened and thus the co-authorship lost).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. typings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tools: lint TypeScript files
7 participants