-
-
Notifications
You must be signed in to change notification settings - Fork 31.6k
tools: lint typescript files #58256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
tools: lint typescript files #58256
Conversation
Review requested:
|
test/fixtures/source-map/output/source_map_throw_async_stack_trace.mts
Outdated
Show resolved
Hide resolved
Hiya! I contributed part of this change, so I'd love if you could add me as a Co-Author. Thanks! |
Co-Authored-By: avivkeller <[email protected]>
Sorry for not doing that before, TIL about co-authoring commits. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58256 +/- ##
==========================================
+ Coverage 90.12% 90.18% +0.05%
==========================================
Files 629 629
Lines 186628 186641 +13
Branches 36622 36651 +29
==========================================
+ Hits 168206 168324 +118
+ Misses 11216 11110 -106
- Partials 7206 7207 +1 🚀 New features to boost your workflow:
|
I think in order for co-authorship to work in this repo, you must add the co-author to the first commit (it's currently applied to an intermediary commit, which will get flattened and thus the co-authorship lost). |
closes #55702 by adding typescript-eslint to the linting rules.
Thanks to @avivkeller for this closed PR #55709.