vm: import call should return a promise in the current context

[legendecas]

A import call should returns a promise created in the context where
the import was called, not the context of importModuleDynamically
callback.

This is also a requirement in ECMA262 https://tc39.es/ecma262/#sec-evaluate-import-call
step 7 and 14:

13.3.10.2 EvaluateImportCall ( specifierExpression [ , optionsExpression ] )
  ...
  7. Let promiseCapability be ! NewPromiseCapability(%Promise%).
  ...
  14. Return promiseCapability.[[Promise]].

Fixes: #53575

[nodejs-github-bot]

Review requested:

• @nodejs/loaders
• @nodejs/vm

[legendecas]

Added a test to cover import rejection as well.

[codecov]

Codecov Report

Attention: Patch coverage is 45.45455% with 6 lines in your changes missing coverage. Please review.

Project coverage is 90.22%. Comparing base (28cbc4c) to head (b464995).
Report is 21 commits behind head on main.

Files with missing lines	Patch %	Lines
src/module_wrap.cc	45.45%	3 Missing and 3 partials ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #58309   +/-   ##
=======================================
  Coverage   90.21%   90.22%           
=======================================
  Files         633      633           
  Lines      186836   186821   -15     
  Branches    36671    36668    -3     
=======================================
+ Hits       168562   168564    +2     
+ Misses      11070    11045   -25     
- Partials     7204     7212    +8     

Files with missing lines	Coverage Δ
src/module_wrap.cc	72.12% <45.45%> (-0.26%)	⬇️

... and 27 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/66800/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/66823/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/66825/