Skip to content

src: remove Environment::GetCurrent(isolate) #58311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented May 13, 2025

Removes Environment::GetCurrent(isolate) calls

cc @nodejs/cpp-reviewers

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/sqlite

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels May 13, 2025
@anonrig anonrig force-pushed the yagiz/refactor-environment-getcurrent branch 2 times, most recently from 3f4dfa8 to 9a1be50 Compare May 13, 2025 13:58
Copy link

codecov bot commented May 13, 2025

Codecov Report

Attention: Patch coverage is 88.09524% with 5 lines in your changes missing coverage. Please review.

Project coverage is 89.68%. Comparing base (2281a04) to head (ea46cf2).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
src/api/hooks.cc 80.00% 2 Missing ⚠️
src/api/callback.cc 75.00% 0 Missing and 1 partial ⚠️
src/api/environment.cc 50.00% 0 Missing and 1 partial ⚠️
src/node_buffer.cc 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #58311      +/-   ##
==========================================
- Coverage   90.21%   89.68%   -0.54%     
==========================================
  Files         633      633              
  Lines      186834   186832       -2     
  Branches    36683    36363     -320     
==========================================
- Hits       168549   167556     -993     
- Misses      11089    12023     +934     
- Partials     7196     7253      +57     
Files with missing lines Coverage Δ
src/api/async_resource.cc 95.23% <100.00%> (ø)
src/api/exceptions.cc 90.69% <100.00%> (-3.49%) ⬇️
src/async_context_frame.cc 100.00% <100.00%> (ø)
src/env-inl.h 94.11% <ø> (-0.08%) ⬇️
src/env.h 98.14% <ø> (ø)
src/node_errors.cc 64.23% <100.00%> (+0.05%) ⬆️
src/node_platform.cc 76.00% <100.00%> (-0.24%) ⬇️
src/node_report.cc 93.23% <100.00%> (ø)
src/node_sqlite.cc 80.58% <100.00%> (ø)
src/node_task_queue.cc 83.48% <100.00%> (-0.92%) ⬇️
... and 5 more

... and 95 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@anonrig anonrig force-pushed the yagiz/refactor-environment-getcurrent branch from 9a1be50 to ea46cf2 Compare May 13, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants