http2: deprecate priority #58313
Open
http2: deprecate priority #58313
+6
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matteo Collina <[email protected]>
|
Review requested:
|
nodejs-github-bot
added
doc
mcollina
added
lts-watch-v20.x
pimterry
reviewed
May 13, 2025
Comment on lines
+1478
to
1479
| and therefore this method is deprecated. | ||
|
|
There was a problem hiding this comment.
Worth noting imo that it's deprecated in the latest HTTP/2 RFCs themselves (RFC 9113, here: https://datatracker.ietf.org/doc/html/rfc9113#section-5.3.1) which is the relevant point for most users. It's not that nghttp2 has just unilaterally dropped support, the whole concept is going away everywhere.
| @@ -1585,6 +1588,8 @@ Provides miscellaneous information about the current state of the | |||
| instances that depend on this `Http2Stream` as specified using | |||
| `PRIORITY` frames. | |||
| * `weight` {number} The priority weight of this `Http2Stream`. | |||
| The support for priority weights has been removed in [latest versions of nghttp2 (1.65.0)][nghttp2-priority], | |||
| and therefore this property is deprecated and it should be ignored. | |||
There was a problem hiding this comment.
This applies to sumDependencyWeight too.
marco-ippolito
approved these changes
May 13, 2025
|
We might have to create an entry in the deprecation.md |
RafaelGSS
reviewed
May 13, 2025
| @@ -1473,6 +1474,8 @@ added: v8.4.0 | |||
| sending a `PRIORITY` frame to the connected peer. | |||
|
|
|||
| Updates the priority for this `Http2Stream` instance. | |||
| The support for priority weights has been removed in [latest versions of nghttp2 (1.65.0)][nghttp2-priority], | |||
There was a problem hiding this comment.
I think we should move this description to the YAML changes: as this will be out-of-date as soon as nghttp releases more versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #58293
and #57269.