zlib: add error handling for trailing junk after stream end #58316
+83
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
errors
0hmX
force-pushed
the
DecompressionStream
branch
2 times, most recently
from
138710a to
002c166
Compare
0hmX
changed the title
Introduce `ERR_TRAILING_JUNK_AFTER_STREAM_END` error to handle unexpected data after the end of a compressed stream. This ensures proper error reporting when decompressing deflate or gzip streams with trailing junk. Added tests to verify the behavior. Fixes: nodejs#58247
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #58316 +/- ##
==========================================
+ Coverage 90.18% 90.23% +0.04%
==========================================
Files 629 633 +4
Lines 186641 186845 +204
Branches 36654 36680 +26
==========================================
+ Hits 168329 168599 +270
+ Misses 11112 11042 -70
- Partials 7200 7204 +4
🚀 New features to boost your workflow:
|
…ive.any.js All subtests in decompression-corrupt input.tentative.any.js now pass, so the "fail.expected" entry has been removed from the status file. This reflects the current passing state of the test suite.
Corrected the formatting of the `ERR_TRAILING_JUNK_AFTER_STREAM_END` section by removing trailing spaces and ensuring consistent line breaks for better readability.
|
cc: @nodejs/zlib |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #58247
Introduce
ERR_TRAILING_JUNK_AFTER_STREAM_ENDerror to handle unexpected data after the end of a compressed stream. This ensures proper error reporting when decompressing deflate or gzip streams with trailing junk. Added tests to verify the behavior.