-
-
Notifications
You must be signed in to change notification settings - Fork 31.6k
doc: clarify the scope of --disallow-code-generation-from-strings
#58328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No.
Documenting the incomplete behavior and setting it in stone would be more problematic, I think.
Instead, #28614 should have respected this flag
Not doing that that is hardly helpful and makes this flag close to useless.
While doing that will very unlikely break anything.
Also the path of least surprise in the behavior is blocking data imports on that flag, like browsers do with CSP.
See also explanation in #58221
Node.js does not support CSP. This flag was originally exposed as a V8 flag, and documented in Node.js, only supporting guarding the listed APIs. #28614 did nothing wrong as the flag was never meant to interfere module system, including |
cc @nodejs/tsc pls discuss this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding a request for change so this doesn't land without @ChALkeR's objection getting dismissed by either Nikita or a TSC vote.
Fixes: #58221