Skip to content

lib: deprecate _stream_* modules #58337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dario-piotrowicz
Copy link
Member

Runtime deprecation of all the _stream_* modules (besides _stream_wrap which is already deprecated)

This PR follows #57643 as part of my effort for trying to deprecate the various _ modules that are not documented
and that should not be part of node.js' public API (for more context see: #57540 (comment))

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/streams

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels May 14, 2025
@dario-piotrowicz dario-piotrowicz added semver-major PRs that contain breaking changes and should be released in the next major version. and removed lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels May 14, 2025
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

file renamed for consistency with the others I'm adding

@dario-piotrowicz dario-piotrowicz force-pushed the dario/deprecate_stream branch from 2bd8325 to 5eda2b3 Compare May 14, 2025 18:40
@dario-piotrowicz dario-piotrowicz changed the title lib: deprecate _stream_* modules lib: deprecate _stream_* modules May 14, 2025
@dario-piotrowicz dario-piotrowicz force-pushed the dario/deprecate_stream branch from 5eda2b3 to 1e6ac2d Compare May 14, 2025 18:41
Copy link

codecov bot commented May 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.23%. Comparing base (b197355) to head (a9137e5).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #58337      +/-   ##
==========================================
- Coverage   90.23%   90.23%   -0.01%     
==========================================
  Files         633      633              
  Lines      186818   186824       +6     
  Branches    36668    36678      +10     
==========================================
+ Hits       168578   168581       +3     
- Misses      11036    11044       +8     
+ Partials     7204     7199       -5     
Files with missing lines Coverage Δ
lib/_stream_duplex.js 100.00% <100.00%> (ø)
lib/_stream_passthrough.js 100.00% <100.00%> (ø)
lib/_stream_readable.js 100.00% <100.00%> (ø)
lib/_stream_transform.js 100.00% <100.00%> (ø)
lib/_stream_wrap.js 100.00% <100.00%> (ø)
lib/_stream_writable.js 100.00% <100.00%> (ø)

... and 29 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dario-piotrowicz dario-piotrowicz force-pushed the dario/deprecate_stream branch from 1e6ac2d to a9137e5 Compare May 14, 2025 20:14
@dario-piotrowicz dario-piotrowicz added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. semver-major PRs that contain breaking changes and should be released in the next major version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants