-
-
Notifications
You must be signed in to change notification settings - Fork 31.6k
lib: deprecate _stream_*
modules
#58337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dario-piotrowicz
wants to merge
1
commit into
nodejs:main
Choose a base branch
from
dario-piotrowicz:dario/deprecate_stream
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
lib: deprecate _stream_*
modules
#58337
dario-piotrowicz
wants to merge
1
commit into
nodejs:main
from
dario-piotrowicz:dario/deprecate_stream
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review requested:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
file renamed for consistency with the others I'm adding
2bd8325
to
5eda2b3
Compare
_stream_*
modules
5eda2b3
to
1e6ac2d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58337 +/- ##
==========================================
- Coverage 90.23% 90.23% -0.01%
==========================================
Files 633 633
Lines 186818 186824 +6
Branches 36668 36678 +10
==========================================
+ Hits 168578 168581 +3
- Misses 11036 11044 +8
+ Partials 7204 7199 -5
🚀 New features to boost your workflow:
|
1e6ac2d
to
a9137e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
lib / src
Issues and PRs related to general changes in the lib or src directory.
needs-ci
PRs that need a full CI run.
semver-major
PRs that contain breaking changes and should be released in the next major version.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runtime deprecation of all the
_stream_*
modules (besides_stream_wrap
which is already deprecated)This PR follows #57643 as part of my effort for trying to deprecate the various
_
modules that are not documentedand that should not be part of node.js' public API (for more context see: #57540 (comment))