doc: fix inconsistencies in CJS code snippets#63199
Open
aduh95 wants to merge 1 commit intonodejs:mainfrom
Open
doc: fix inconsistencies in CJS code snippets#63199aduh95 wants to merge 1 commit intonodejs:mainfrom
aduh95 wants to merge 1 commit intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
86425e7 to
ca2a4b6
Compare
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
ca2a4b6 to
f230a6d
Compare
Member
|
Isn't importing process from |
Contributor
Author
It's enforced on ESM files/code snippets (IIRC the rationale is that folks writing CJS are likely writing Node.js-only code, and therefore will be more likely to use Node.js-only globals – and conversely, folks writing ESM would be more likely to not want to use Node.js-only globals) |
JakobJingleheimer
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of our snippets have
'use strict'statement and importprocessfromnode:process, and the vast majority does not (not explicit'use strict', and use the globalprocess).