Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: workflow #92

Merged
merged 3 commits into from
Jun 23, 2024
Merged

fix: workflow #92

merged 3 commits into from
Jun 23, 2024

Conversation

AugustinMauroy
Copy link
Member

No description provided.

@AugustinMauroy
Copy link
Member Author

I hate jest I can't reproduce this issue on my machine

@UlisesGascon UlisesGascon mentioned this pull request Jun 22, 2024
Merged
@UlisesGascon
Copy link
Member

Same! test are passing locally with 18.x and 22.x but not in the CI. Seems like the issue might be related to the timezone #90 (comment)

@AugustinMauroy
Copy link
Member Author

YEAH it's green ! I didn't know that changing time zones with node was a good thing.

@UlisesGascon
Copy link
Member

YEAH it's green ! I didn't know that changing time zones with node was a good thing.

As I used hardcoded dates for the tests, the machine was not able to replicate the same results if the machine is setup in different timezone. The GitHub action runner probably will be located in the US and I created the tests using Madrid timezone :).

If you want to refactor this further, you can always add process.env.TZ='Europe/Amsterdam' directly in the __tests__/utils.test.js (line ref).

@UlisesGascon UlisesGascon merged commit c52eac7 into nodejs:main Jun 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UlisesGascon UlisesGascon UlisesGascon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AugustinMauroy @UlisesGascon