chore(ui): move ArticleLayout to ui-components
#7762
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Pull Request Overview
This PR moves the ArticleLayout component into the ui-components library so that it can be re-used by api-docs-tooling for JSX generation.
- Updated the ArticleLayout import and its corresponding CSS module file reference in ui-components.
- Removed duplicate ArticleLayout styling from the site layouts and updated several layouts to use the new Article component.
- Adjusted import paths in Learn.tsx, Default.tsx, ArticlePage.tsx, and About.tsx to reference the new shared component.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/ui-components/Containers/Article/index.tsx | Updated to import the new CSS module file (index.module.css). |
| packages/ui-components/Containers/Article/index.module.css | Added new Article layout CSS using Tailwind utilities. |
| apps/site/layouts/layouts.module.css | Removed duplicated ArticleLayout styling. |
| apps/site/layouts/Learn.tsx | Updated to use the new Article component from ui-components. |
| apps/site/layouts/Default.tsx | Updated to use the new Article component from ui-components. |
| apps/site/layouts/ArticlePage.tsx | Updated to use the new Article component from ui-components. |
| apps/site/layouts/About.tsx | Updated to use the new Article component from ui-components. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #7762 +/- ##
==========================================
- Coverage 75.10% 75.06% -0.04%
==========================================
Files 98 98
Lines 7914 7914
Branches 196 196
==========================================
- Hits 5944 5941 -3
- Misses 1969 1972 +3
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
github-actions
bot
removed
the
github_actions:pull-request
|
Lighthouse Results
|
AugustinMauroy
approved these changes
May 20, 2025
github-actions
bot
removed
the
github_actions:pull-request
bmuenzenmeyer
approved these changes
May 21, 2025
aymen94
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm moving this component into the
ui-componentslibrary so it can be re-used byapi-docs-toolingas part of the JSX generation.