-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
chore(download): remove windows instructions from fnm #7769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR reclassifies the installation method of fnm by removing it from the "Recommended" list and placing it under "Community."
- Removed the "recommended": true flag from the fnm configuration in constants.json.
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #7769 +/- ##
==========================================
+ Coverage 75.09% 75.36% +0.26%
==========================================
Files 98 96 -2
Lines 7914 7858 -56
Branches 196 192 -4
==========================================
- Hits 5943 5922 -21
+ Misses 1970 1935 -35
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
👀 Could I suggest that we just remove the broken Windows option, instead of downgrading fnm across all platforms? I see no reason for us to keep the Windows instructions, recommended or not, when they're broken, but the macOS/Linux instructions seem perfectly fine to continue recommending? |
c8b6250
to
e7fe0d0
Compare
Done. No snippets need to be changed as the Windows version uses the same snippet (with an |
Unfortunately, because there was response in #7487 to multiple requests over the past few weeks, this PR removes the Windows instructions from fnm.
CC @Schniz