chore(ui): don't depend on pnpm syntax #7771
Open
+5
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Pull Request Overview
This PR removes the non-npm workspace:* dependency and inlines the SimpleLocaleConfig type to eliminate reliance on an external interface.
- Inline
SimpleLocaleConfiginstead of usingPick<LocaleConfig>and drop theLocaleConfigimport - Remove
"@node-core/website-i18n": "workspace:*"fromdevDependencies
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/ui-components/types.ts | Inlined SimpleLocaleConfig properties and removed external import |
| packages/ui-components/package.json | Deleted workspace syntax for @node-core/website-i18n |
Comments suppressed due to low confidence (2)
packages/ui-components/package.json:50
- [nitpick] Since the
workspace:*syntax was removed, pin@node-core/website-i18nto a fixed npm version (e.g.,^1.2.3) so consumers get a predictable release instead of missing the dependency entirely.
"@node-core/website-i18n": "workspace:*",
packages/ui-components/types.ts:21
- [nitpick] Consider adding a JSDoc comment to
SimpleLocaleConfigexplaining its shape and reminding maintainers to sync it with the upstreamLocaleConfiginterface to avoid divergence over time.
export type SimpleLocaleConfig = {
avivkeller
force-pushed
the
chore/ui/no-pnpm
branch
from
5186012 to
40fd13c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #7771 +/- ##
==========================================
+ Coverage 75.34% 75.36% +0.01%
==========================================
Files 96 96
Lines 7858 7858
Branches 192 192
==========================================
+ Hits 5921 5922 +1
+ Misses 1936 1935 -1
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
AugustinMauroy
approved these changes
May 21, 2025
github-actions
bot
removed
the
github_actions:pull-request
|
Lighthouse Results
|
bmuenzenmeyer
approved these changes
May 22, 2025
canerakdas
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we import
@node-core/ui-componentsfromapi-docs-tooling, it can't contain non-npm syntax in it'spackage.json. Therefore, this PR removes the dependency on theworkspace:*syntax.