Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(proxy-agent): add fallback value for servername when using reques… #3989

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(proxy-agent): add fallback value for servername when using reques… #3989

wants to merge 1 commit into from

Conversation

Viiprogrammer
Copy link

@Viiprogrammer Viiprogrammer commented Jan 5, 2025 •
edited
Loading

This relates to...

#3988

Changes

Added fallback for requestTls.servername

Bug Fixes

Fix servername when using requestTls #3988

Status

metcoder95
metcoder95 reviewed Jan 5, 2025
View reviewed changes
Copy link
Member

@metcoder95 metcoder95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test for it?

@Viiprogrammer
Copy link
Author

Can you add a test for it?

Need to be covered by tests like here ?

Yes, I'll add tests if needed

@metcoder95
Copy link
Member

Can you add a test for it?

Need to be covered by tests like here ?

Yes, I'll add tests if needed

sure, that works 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metcoder95 metcoder95 metcoder95 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Viiprogrammer @metcoder95