-
Notifications
You must be signed in to change notification settings - Fork 18
Node v24.15.0 nsolid v6.2.3 release #451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
santigimeno
wants to merge
272
commits into
node-v24.x-nsolid-v6.x
Choose a base branch
from
node-v24.15.0-nsolid-v6.2.3-release
base: node-v24.x-nsolid-v6.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
272 commits
Select commit
Hold shift + click to select a range
196268c
deps: V8: cherry-pick c5ff7c4d6cde
legendecas 83dfd0b
buffer: disallow ArrayBuffer transfer on pooled buffer
legendecas c851e76
net: add `setTOS` and `getTOS` to `Socket`
amyssnippet ea9beb6
doc: update to Visual Studio 2026 manual install
MikeMcC399 ae5e353
doc: clean up Windows code snippet in `child_process.md`
reillylm 687c0ac
http2: fix FileHandle leak in respondWithFile
Han5991 171e9fc
esm: update outdated FIXME comment in translators.js
karan-lrn c28a22c
src: fix cjs_lexer external reference registration
joyeecheung b7cd31a
doc: fix broken links of net.md
samuel871211 6e1197a
src: add more checks and clarify docs for external references
joyeecheung 94097a7
doc: move describe/it aliases section before expectFailure
lraveri e8079a8
src: release memory for zstd contexts in `Close()`
addaleax bef661f
src: extract zlib allocation tracking into its own class
addaleax 94dbb36
src: do not store compression methods on Brotli classes
addaleax 3c8f700
src: track allocations made by zstd streams
addaleax bc38db5
tools: fix small inconsistencies in JSON doc output
aduh95 e0220f0
build: build with v8 gdbjit support on supported platform
joyeecheung 276a32f
test: update WPT for url to efb889eb4c
nodejs-github-bot 84c7a23
test: update WPT for WebCryptoAPI to 7cbe7e8ed9
nodejs-github-bot b3387b0
deps: update googletest to 5a9c3f9e8d9b90bbbe8feb32902146cb8f7c1757
nodejs-github-bot 4ff01b5
doc: fix spacing in process message event
avivkeller 49254e3
doc: fix dropdown menu being obscured at <600px due to stacking context
leolightwork e558b26
doc: add riscv64 info into platform list
luyahan 0312db9
doc: fix methods being documented as properties in `process.md`
aduh95 6834ca1
stream: rename `Duplex.toWeb()` type option to `readableType`
Renegade334 f4a3edc
fs: add `throwIfNoEntry` option for fs.stat and fs.promises.stat
juanarbol 2bf990b
doc: update Juan's security steward info
juanarbol 458c92b
events: don't call resume after close
ChALkeR 0d1975f
build,win: add WinGet Visual Studio 2022 Build Tools Edition config
MikeMcC399 fe15b0d
tools: bump the eslint group in /tools/eslint with 6 updates
dependabot[bot] 00df3c1
tools: bump unist-util-visit in /tools/doc in the doc group
dependabot[bot] 72aad8b
crypto: always return certificate serial numbers as uppercase
addaleax a810f5c
doc: clarify async caveats for `events.once()`
Renegade334 26c6045
src: use bool literals in TraceEnvVarOptions
tniessen 207ba4f
test_runner: fix suite rerun
MoLow 5cf0017
test: update FileAPI tests from WPT
Ms2ger a9c5bd2
zlib: add support for brotli compression dictionary
rokob 9ad0206
test: adapt buffer test for v8 sandbox
codebytere deeeb22
worker: eliminate race condition in process.cwd()
giulioAZ 1c2064c
http: fix keep-alive socket reuse race in requestOnFinish
martinslota 6cda3d3
src: remove unnecessary `c_str()` conversions in diagnostic messages
addaleax 5cdcba1
http2: add http1Options for HTTP/1 fallback configuration
amyssnippet 1ca20fc
test_runner: show interrupted test on SIGINT
mcollina a0316d3
watch: get flags from execArgv
efekrskl 460f412
test: check stability block position in API markdown
Renegade334 08d2e40
http: attach error handler to socket synchronously in onSocket
RajeshKumar11 2cf77ea
build: generate_config_gypi.py generates valid JSON
codebytere 6fec397
doc: clean up globals.md
Renegade334 9502c22
doc: simplify addAbortListener example
atlowChemi 5dd48e3
doc: remove incorrect mention of `module` in `typescript.md`
robpalme c7607b9
tools: automate updates for test/fixtures/test426
Trott af46b15
build: use path-ignore in GHA coverage-windows.yml
legendecas 5266887
deps: update llhttp to 9.3.1
nodejs-github-bot 899884d
http: remove redundant keepAliveTimeoutBuffer assignment
efekrskl d79984b
lib: optimize styleText when validateStream is false
RafaelGSS ec2913f
test: unify assertSnapshot stacktrace transform
legendecas a20bf9a
test: allow filtering async internal frames in assertSnapshot
joyeecheung 1017bf5
lib: remove top-level getOptionValue() calls in lib/internal/modules
joyeecheung a03b5d3
lib: reduce cycles in esm loader and load it in snapshot
joyeecheung 837acd7
benchmark: add startup benchmark for ESM entrypoint
joyeecheung 240b512
doc: clarify build environment is trusted in threat model
mcollina 569767e
stream: add fast paths for webstreams read and pipeTo
mcollina 5626cb8
deps: remove stale OpenSSL arch configs
Renegade334 0958f9a
tools: do not checkout repo in `auto-start-ci.yml`
aduh95 937cd97
tools: fix auto-start-ci
aduh95 4b2e4bb
deps: update nbytes to 0.1.3
nodejs-github-bot aaf9af1
sqlite: mark as release candidate
mcollina 38e9c66
http2: add strictSingleValueFields option to relax header validation
pimterry 22b748e
test: fix typos in test files
watilde bd0688f
doc: add esm and cjs examples to node:vm
mfdebian a5a1448
doc: clarify status of feature request issues
aduh95 15f32b4
stream: fix decoded fromList chunk boundary check
watson 498abf6
meta: bump actions/stale from 10.1.1 to 10.2.0
dependabot[bot] 16c839a
meta: bump step-security/harden-runner from 2.14.1 to 2.14.2
dependabot[bot] 830e5cd
meta: bump github/codeql-action from 4.32.0 to 4.32.4
dependabot[bot] 34b6305
tools: roll back to x86 runner on `scorecard.yml`
aduh95 d8204d3
doc: rename invalid `function` parameter
Renegade334 463dfa0
deps: update minimatch to 10.2.2
nodejs-github-bot 8bbe013
util: add fast path to stripVTControlCharacters
privatenumber 78fa1a1
doc: support toolchain Visual Studio 2022 & 2026 + Windows 11 SDK
MikeMcC399 8d0c22e
crypto: fix potential null pointer dereference when BIO_meth_new() fails
ndossche b1199c7
test_runner: replace native methods with primordials
Ayoub-Mabrouk 1f2025f
test_runner: expose worker ID for concurrent test execution
thisalihassan 10b2bb5
child_process: add tracing channel for spawn
marcopiraccini f0e40b3
deps: update acorn to 8.16.0
nodejs-github-bot a13bee7
deps: update acorn-walk to 8.3.5
nodejs-github-bot 290fe37
deps: update simdjson to 4.3.1
nodejs-github-bot 7302c7e
crypto: fix handling of null BUF_MEM* in ToV8Value()
ndossche 54009e9
doc: explicitly mention Slack handle
RafaelGSS eb77a7a
src: add C++ support for diagnostics channels
RafaelGSS 65aa8f6
stream: fix pipeTo to defer writes per WHATWG spec
mcollina 8287ca7
test_runner: expose expectFailure message
Han5991 bd5458d
crypto: fix missing nullptr check on RSA_new()
ndossche d74efd6
test_runner: run afterEach on runtime skip
igor-shevelenkov 7de8a30
inspector: unwrap internal/debugger/inspect imports
Renegade334 d91a689
tools: bump minimatch from 3.1.2 to 3.1.3 in /tools/eslint
dependabot[bot] c0680d5
test: avoid flaky debugger restart waits
inoway46 16b8cc6
lib: improve argument handling in Blob constructor
Ms2ger 2ea0672
test: skip strace test with shared openssl
richardlau a82003b
buffer: optimize buffer.concat performance
mertcanaltin 6ac4304
sqlite: add limits property to DatabaseSync
mertcanaltin 774d0be
tools: revert tools GHA workflow to ubuntu-latest
richardlau 9927335
tls: forward keepAlive, keepAliveInitialDelay, noDelay to socket
tadjik1 dd1139f
doc: update DEP0040 (punycode) to application type deprecation
MikeMcC399 8511b1c
doc: fix module.stripTypeScriptTypes indentation
Renegade334 1319295
test: skip `test-url` on `--shared-ada` builds
aduh95 f79df03
test: remove unnecessary `process.exit` calls from test files
aduh95 492868a
tools: fix permissions for merve update script
richardlau 191c433
doc: fix small logic error in DETECT_MODULE_SYNTAX
Renegade334 de1bcfd
tools: bump minimatch from 3.1.2 to 3.1.3 in `/tools/clang-format`
dependabot[bot] 671ddec
deps: update minimatch to 10.2.4
nodejs-github-bot dbb3551
doc: separate in-types and out-types in SQLite conversion docs
Renegade334 2df328d
src: fix flags argument offset in JSUdpWrap
cuiweixie f8178ac
http: validate headers in writeEarlyHints
rsclarke 309f37b
doc: expand SECURITY.md with non-vulnerability examples
RafaelGSS 46cfad4
module: run require.resolve through module.registerHooks()
joyeecheung 0a4ad85
http: validate ClientRequest path on set
mcollina 6f93c4b
tools: fix parsing of commit trailers in `lint-release-proposal` GHA
aduh95 79fb8cb
src: use validate_ascii_with_errors instead of validate_ascii
ChALkeR ad97045
doc: include url.resolve() in DEP0169 application deprecation
MikeMcC399 d886f27
test: fix skipping behavior for `test-runner-run-files-undefined`
aduh95 a3751f2
stream: accept ArrayBuffer in CompressionStream and DecompressionStream
suuuuuuminnnnnn 2f9c085
sqlite: handle stmt invalidation
araujogui fb1c0bd
test: update WPT for WebCryptoAPI to 42e47329fd
nodejs-github-bot 7ab885b
deps: update ada to 3.4.3
nodejs-github-bot 4213f89
src: release context frame in AsyncWrap::EmitDestroy
Flarna 42057c8
doc,module: add missing doc for syncHooks.deregister()
joyeecheung 59ad1e4
tools: bump eslint to v10, babel to v8.0.0-rc.2
JLHwung b067d74
meta: bump step-security/harden-runner from 2.14.2 to 2.15.0
dependabot[bot] 78a9aa8
lib: fix source map url parse in dynamic imports
legendecas 5245900
tools: bump minimatch from 3.1.3 to 3.1.5 in /tools/clang-format
dependabot[bot] db516ec
doc: fix markdown for `expectFailure` values
JakobJingleheimer 531e62c
stream: fix TransformStream race on cancel with pending write
marcopiraccini 30476dd
tools: fix example in release proposal linter
richardlau 54dc797
tools: fix daily wpt workflow nighly release version lookup
panva bd34e53
tools: bump the eslint group across 1 directory with 2 updates
dependabot[bot] dbe5898
stream: fix UTF-8 character corruption in fast-utf8-stream
mcollina 58e4d50
http: fix use-after-free when freeParser is called during llhttp_execute
Flarna 8b8db52
crypto: fix importKey required argument count check
panva e293416
crypto: add missing AES dictionaries
panva a4466eb
doc: add efekrskl as triager
efekrskl d788467
src: expose async context frame debugging helper to JS
addaleax 9536e56
test: update WPT compression to ae05f5cb53
panva dc66a05
test: improve WPT report runner
panva cdec579
stream: improve Web Compression spec compliance
panva fcf2a9f
stream: fix brotli error handling in web compression streams
panva 840e098
tools: improve error handling in test426 update script
Trott 5bb8991
meta: bump actions/upload-artifact from 6.0.0 to 7.0.0
dependabot[bot] 6462b89
meta: bump actions/download-artifact from 7.0.0 to 8.0.0
dependabot[bot] 7f989f0
doc: correct `util.convertProcessSignalToExitCode` validation behavior
Renegade334 f6cdfbf
stream: optimize webstreams pipeTo
MattiasBuelens b887657
deps: V8: cherry-pick aa0b288f87cc
richardlau 0b6fa91
tools: revert timezone update GHA workflow to ubuntu-latest
richardlau 8c46a1c
doc: copyedit `addons.md`
aduh95 4e15e5b
test: update WPT for WebCryptoAPI to c9e955840a
nodejs-github-bot 12ba2d7
test: update WPT for url to c928b19ab0
nodejs-github-bot 43159d0
deps: update sqlite to 3.52.0
nodejs-github-bot 84f60c2
deps: update amaro to 1.1.8
nodejs-github-bot 71a2f82
deps: upgrade npm to 11.11.1
npm-cli-bot 3d87eca
cli: add --max-heap-size option
tannal 4691f3e
fs: fix cpSync to handle non-ASCII characters
StefanStojanovic 795d663
tools: keep GN files when updating Merve
aduh95 20cb932
crypto: read algorithm name property only once in normalizeAlgorithm
panva 8aa6e70
crypto: refactor WebCrypto AEAD algorithms auth tag handling
panva 44bde8e
doc: add note (and caveat) for `mock.module` about customization hooks
JakobJingleheimer dc54137
stream: replace bind with arrow function for onwrite callback
thisalihassan 4c12ab8
typings: rationalise TypedArray types
Renegade334 fc9a60e
test: update WPT for WebCryptoAPI to 6a1c545d77
nodejs-github-bot a141ad0
doc: remove outdated Chrome 66 and ndb references from debugger
kovan 9dc102b
lib: prefer primordials in SubtleCrypto
panva af8d092
test: add WebCrypto Promise.prototype.then pollution regression tests
panva f7a408d
wasm: support js string constant esm import
guybedford f3fd7ed
deps: update googletest to 73a63ea05dc8ca29ec1d2c1d66481dd0de1950f1
nodejs-github-bot ace802e
diagnostics_channel: add diagnostics channels for web locks
IlyasShabi eee96f7
worker: heap profile optimizations
IlyasShabi bad48b9
tools: validate all commits that are pushed to `main`
aduh95 aad7b3c
url: enable simdutf for ada
anonrig 125bdbf
doc: clarify that any truthy value of `shell` is part of DEP0190
aduh95 2c9436b
benchmark: fix destructuring in dgram/single-buffer
thisalihassan 679d18b
esm: fix path normalization in `finalizeResolution`
aduh95 bc5b9a0
tools: bump flatted from 3.3.3 to 3.4.1 in /tools/eslint
dependabot[bot] 952d715
deps: update sqlite to 3.51.3
nodejs-github-bot 7b28fb9
util: allow color aliases in styleText
Han5991 a035bd5
doc,test: clarify --eval syntax for leading '-' scripts
kovan 78ac17f
module: fix coverage of mocked CJS modules imported from ESM
marcopiraccini ba0a82a
doc: clarify fs.ReadStream and fs.WriteStream are not constructable
kovan 83416a6
test: skip test-cluster-dgram-reuse on AIX 7.3
sxa 70f8057
src: use stack allocation in indexOf latin1 path
mertcanaltin 0291be5
doc: test and test-only targets do not run linter
Xstoudi c44f53b
stream: preserve error over AbortError in pipeline
marcopiraccini f5d74f8
tools: add eslint-plugin-regexp
JLHwung 490168c
doc: fix small environment_variables typo
chohner 09f7920
build: fix timezone-update path references
legendecas 2cb3573
src,sqlite: fix filterFunc dangling reference
geeksilva97 e0cde40
test_runner: set non-zero exit code when suite errors occur
geeksilva97 59ac10a
lib: make SubtleCrypto.supports enumerable
panva 57b105c
doc: deprecate CryptoKey use in node:crypto
panva bfc8a12
test_runner: make it compatible with fake timers
mcollina 3db35d2
doc: add path to vulnerabilities.json mention
RafaelGSS 93d19b1
doc: minor typo fix
JeffMatson 384a410
doc: enhance clarification about the main field
SuperMo0 dc034a4
crypto: reject ML-KEM/ML-DSA PKCS#8 import without seed in SubtleCrypto
panva b0cbfe3
crypto: add crypto::GetSSLCtx API for addon access to OpenSSL contexts
pimterry c4567e4
doc: fix overstated Date header requirement in response.sendDate
kovan f102e79
tools: bump eslint deps
JLHwung b53377e
tools: bump flatted from 3.4.1 to 3.4.2 in /tools/eslint
dependabot[bot] 1c3d93b
test: avoid flaky run wait in debugger restart test
inoway46 4f553cd
src: enable compilation/linking with OpenSSL 4.0
panva 12b04d1
doc: add Rafael to last security release steward
RafaelGSS b93bf7d
esm: fix source phase identity bug in loadCache eviction
guybedford b15ea64
zlib: fix use-after-free when reset() is called during write
mcollina f5f21d3
test_runner: add exports option for module mocks
Han5991 a6ced7d
buffer: improve performance of multiple Buffer operations
thisalihassan 4c206ec
quic: remove CryptoKey support from session keys option
panva deb0b78
esm: fix typo in worker loader hook comment
jakecastelli 4d9123e
deps: upgrade npm to 11.12.1
npm-cli-bot a416ddf
deps: V8: cherry-pick cf1bce40a5ef
richardlau cd84af7
src: handle null backing store in ArrayBufferViewContents::Read
mertcanaltin 1dbf3be
src: improve EC JWK import performance
panva 0897c6c
test: disable flaky WPT Blob test on AIX
jasnell 111ba9b
test: wait for reattach before initial break on restart
inoway46 90fab71
deps: update simdjson to 4.5.0
nodejs-github-bot ed2d0cb
build: support empty libname flags in `configure.py`
aduh95 1c6f5ed
tools: adopt the `--check-for-duplicates` NCU flag
aduh95 19a52a1
test: update WPT for url to fc3e651593
nodejs-github-bot 56741a1
doc: move sqlite type conversion section to correct level
Renegade334 53aad66
deps: update googletest to 2461743991f9aa53e9a3625eafcbacd81a3c74cd
nodejs-github-bot 0c8f802
inspector: add Target.getTargets and extract TargetManager
cola119 a1c3c90
tools: bump picomatch from 4.0.3 to 4.0.4 in /tools/eslint
dependabot[bot] d0418ba
deps: update timezone to 2026a
nodejs-github-bot 2e1a565
deps: update ada to 3.4.4
nodejs-github-bot 9d37233
crypto: update root certificates to NSS 3.121
nodejs-github-bot 1ecc596
doc: fix 'transfered' typo in quic.md
lilianakatrina684-a11y 12fc3c6
doc: clarify that features cannot be both experimental and deprecated
aduh95 7f234ad
doc: deprecate `module.register()` (DEP0205)
GeoffreyBooth bef1949
deps: V8: cherry-pick 33e7739c134d
thibaudmichaud 73ea387
doc: remove obsolete Boxstarter automated install
MikeMcC399 3c9c0f8
test: fix test-buffer-zero-fill-cli to be effective
ChALkeR 0b15244
doc: fix typo in --disable-wasm-trap-handler description
x0m4ek d8ea1aa
src: make AsyncWrap subclass internal field counts explicit
addaleax 8357ebf
url: suppress warnings from url.format/url.resolve inside node_modules
Renegade334 7d67e5d
src: convert context_frame field in AsyncWrap to internal field
addaleax cc19728
events: avoid cloning listeners array on every emit
gurgunday 5ed5474
test: update WPT for WebCryptoAPI to 2cb332d710
nodejs-github-bot a072411
doc: remove spawn with shell example from bat/cmd section
kovan 8484306
2026-04-15, Version 24.15.0 'Krypton' (LTS)
nodejs-github-bot 1dd74e4
Merge tag 'v24.15.0' into node-v24.15.0-nsolid-v6.2.3-release
santigimeno 27285b3
src: fix C++ linting issues
santigimeno a4ea1b4
lib,test: fix JS linting errors
santigimeno c86d1e3
2026-04-20, Version 24.15.0-nsolid-v6.2.3 'Krypton'
santigimeno File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| # yaml-language-server: $schema=https://aka.ms/configuration-dsc-schema/0.2 | ||
| # Reference: https://github.com/nodejs/node/blob/main/BUILDING.md#windows | ||
| properties: | ||
| resources: | ||
| - resource: Microsoft.WinGet.DSC/WinGetPackage | ||
| id: pythonPackage | ||
| directives: | ||
| description: Install Python 3.14 | ||
| module: Microsoft.WinGet.DSC | ||
| allowPrerelease: true | ||
| settings: | ||
| id: Python.Python.3.14 | ||
| source: winget | ||
| - resource: Microsoft.WinGet.DSC/WinGetPackage | ||
| id: vsPackage | ||
| directives: | ||
| description: Install Visual Studio 2022 Build Tools | ||
| allowPrerelease: true | ||
| settings: | ||
| id: Microsoft.VisualStudio.2022.BuildTools | ||
| source: winget | ||
| useLatest: true | ||
| - resource: Microsoft.VisualStudio.DSC/VSComponents | ||
| id: vsComponents | ||
| dependsOn: | ||
| - vsPackage | ||
| directives: | ||
| description: Install required VS workloads and components | ||
| allowPrerelease: true | ||
| settings: | ||
| productId: Microsoft.VisualStudio.Product.BuildTools | ||
| channelId: VisualStudio.17.Release | ||
| includeRecommended: true | ||
| components: | ||
| - Microsoft.VisualStudio.Workload.VCTools | ||
| - Microsoft.VisualStudio.Component.VC.Llvm.Clang | ||
| - Microsoft.VisualStudio.Component.VC.Llvm.ClangToolset | ||
| - resource: Microsoft.WinGet.DSC/WinGetPackage | ||
| id: gitPackage | ||
| directives: | ||
| description: Install Git | ||
| allowPrerelease: true | ||
| settings: | ||
| id: Git.Git | ||
| source: winget | ||
| - resource: Microsoft.WinGet.DSC/WinGetPackage | ||
| id: nasmPackage | ||
| directives: | ||
| description: Install NetWide Assembler (NASM) | ||
| allowPrerelease: true | ||
| settings: | ||
| id: Nasm.Nasm | ||
| source: winget | ||
| configurationVersion: 0.1.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🌐 Web query:
In GitHub Actions, dopull_request.paths-ignoreandpush.paths-ignoresupport negated patterns like!pathto re-include files? What is the documented approach to include one workflow file while broadly ignoring dotfiles?💡 Result:
Yes—GitHub Actions path filters support negated patterns (glob patterns prefixed with !) but they apply within the paths filter, not within paths-ignore. 1) paths-ignore does NOT re-include via ! - The documented semantics for paths-ignore are: “When all the path names match patterns in paths-ignore, the workflow will not run. If any path names do not match patterns in paths-ignore … the workflow will run.” This means paths-ignore is purely an exclusion list; you can’t reliably “subtract then add back” using ! inside paths-ignore. 2) Documented approach: use paths with positive pattern(s) plus ! exclusions - If you want both include and exclude logic for one event, the docs say to use the paths filter and prefix excluded entries with ! (negative patterns). - Also, if you define a ! negated path, you must define at least one non-! (positive) pattern. Practical example (broadly ignore dotfiles, but still include one specific workflow file) - Put a broad positive include for what you want to generally consider, then exclude dotfiles, and finally add back the specific file using another negated/excluded ordering rule via paths. - Example structure: on: pull_request: paths: - '' - '!/.*' # ignore dotfiles/hidden files and hidden directories - '!.github/workflows/ci.yml' # re-include one workflow file (note: must be expressed in paths, not paths-ignore) Notes: - Use paths (not paths-ignore) when you need “ignore dotfiles but include one file” behavior. - The docs also note ordering matters and that negated patterns are evaluated in order. Sources support: - GitHub Docs: paths/paths-ignore behavior and the rule that for include+exclude you must use paths with !, plus the requirement for at least one positive pattern when using !.
Citations:
Remove negation patterns from
paths-ignore—they don't re-include files.paths-ignorein GitHub Actions does not support negation patterns (prefixed with!). The pattern!.github/workflows/coverage-windows.ymlon lines 28 and 54 has no effect. Combined with the.**pattern, changes to this workflow file itself will be ignored, preventing the workflow from running on its own edits.Suggested fix
pull_request: types: [opened, synchronize, reopened, ready_for_review] paths-ignore: @@ - - .** - - '!.github/workflows/coverage-windows.yml' @@ push: @@ paths-ignore: @@ - - .** - - '!.github/workflows/coverage-windows.yml'Also applies to: 32-54
🤖 Prompt for AI Agents