-
Notifications
You must be signed in to change notification settings - Fork 20
Node v24.16.0 nsolid v6.3.0 release #473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
santigimeno
merged 233 commits into
node-v24.x-nsolid-v6.x
from
node-v24.16.0-nsolid-v6.3.0-release
Jun 18, 2026
Merged
Changes from all commits
Commits
Show all changes
233 commits
Select commit
Hold shift + click to select a range
9fe7634
Working on v24.15.1
aduh95 cb67a92
deps: use npm undici@seven tag in `update-undici.sh`
mcollina b39508b
deps: update undici to 7.25.0
nodejs-github-bot 37d49f3
process: optimize asyncHandledRejections by using FixedQueue
gurgunday be4d2f3
sqlite: enable Percentile extension
TheOneTheOnlyJJ 493ac40
deps: update libuv to 1.52.1
nodejs-github-bot 57ef845
deps: update icu to 78.3
nodejs-github-bot 7597d20
crypto: add support for Ed25519 context parameter
panva ad9a290
src: workaround AIX libc++ std::filesystem bug
richardlau 40ccfde
fs: expose frsize field in statfs
verycosy dd43eff
test_runner: add passed, attempt, and diagnostic to SuiteContext
MoLow 938af9b
doc: mention test runner retry attemp is zero based
MoLow db9497f
meta: expand memory leak DoS criteria to all DoS
joyeecheung 332088f
tools: do not run `commit-lint` on release proposals
aduh95 ada3ce8
lib: defer AbortSignal.any() following
Han5991 1fee265
tools: allow triagers to queue a PR for CI until it's reviewed
aduh95 6b53efb
module,win: fix long subpath import
StefanStojanovic ca16ad8
meta: require DCO signoff in commit message guidelines
jasnell 5ee40d6
meta: bump actions/cache from 5.0.3 to 5.0.4
dependabot[bot] 6c00124
meta: bump codecov/codecov-action from 5.5.2 to 6.0.0
dependabot[bot] 73fcc2b
meta: bump github/codeql-action from 4.32.4 to 4.35.1
dependabot[bot] 769efc0
meta: bump actions/setup-node from 6.2.0 to 6.3.0
dependabot[bot] a869d25
meta: bump step-security/harden-runner from 2.15.0 to 2.16.1
dependabot[bot] 81bac1e
tools: bump the eslint group in /tools/eslint with 2 updates
dependabot[bot] aa1d8a9
http: add req.signal to IncomingMessage
akshatsrivastava11 9f3bc70
http: cleanup pipeline queue
ronag 736ed8a
doc: document TransformStream transformer.cancel option
TomStrepsil b267f6b
crypto: implement randomUUIDv7()
nabeel378 7ce95af
deps: libuv: cherry-pick aabb7651de
santigimeno a71a4ac
src: add contextify interceptor debug logs
legendecas 86d4f07
doc: update bug bounty program
RafaelGSS 4739c45
test: update WPT for url to 7a3645b79a
nodejs-github-bot 23f9275
test: use on-disk fixture for test-npm-install
joyeecheung 099ded5
deps: update simdjson to 4.6.1
nodejs-github-bot fa46c90
deps: update googletest to d72f9c8aea6817cdf1ca0ac10887f328de7f3da2
nodejs-github-bot 2faba66
deps: update minimatch to 10.2.5
nodejs-github-bot 6f37f7e
stream: propagate destruction in duplexPair
aelhor f1a6e9f
test: allow skipping individual WPT subtests
panva 5dad616
meta: populate apt list for slim runner in update-openssl workflow
Renegade334 609c013
tools: revert OpenSSL update workflow to ubuntu-latest
richardlau 7b1211f
test: capture negative utimes mtime at call time
inoway46 be23b75
tools: improve output for unexpected passes in WTP tests
aduh95 67e0ac5
meta: move Michael to emeritus
mhdawson 1684ab8
doc: note non-monotonic clock in crypto.randomUUIDv7
nabeel378 9705f62
fs: add signal option to fs.stat()
mertcanaltin 9dd5540
crypto: add memory tracking for secureContext openssl objects
mertcanaltin 6151999
src: use stack allocation for small string encoding
thisalihassan d73dbb9
stream: refactor duplexify to be less suceptible to prototype pollution
aduh95 dd72df0
assert,util: fix stale nested cycle memo entries
BridgeAR 29b1966
stream: noop pause/resume on destroyed streams
ronag e04e2c9
test: skip url WPT subtests instead of modifying test script
panva ef384fe
meta: add QUIC to CODEOWNERS
pimterry 9e21711
test: improve WPT runner summary
panva 85d83c2
test: ensure WPT report is in out/wpt
panva d202e2d
deps: upgrade openssl sources to openssl-3.5.6
nodejs-github-bot b476885
deps: update archs files for openssl-3.5.6
nodejs-github-bot 0b4e0d3
test: update tls junk data error expectations
panva 978afea
doc: fix spelling in release announcement guidance
Rohan5commit c400d46
tools: improve backport review script
aduh95 3ed7835
stream: fix writev unhandled rejection in fromWeb
Han5991 3c96ae1
sqlite: add serialize() and deserialize()
thisalihassan c58fe38
watch: fix --env-file-if-exists crashing on linux if the file is missing
efekrskl 2f37f91
sqlite: use OneByte for ASCII text and internalize col names
thisalihassan f00cdab
stream: simplify `createPromiseCallback`
aduh95 8126d1c
doc: update WPT test runner README.md
panva 70b4d58
doc: clarify Backport-PR-URL metadata added automatically
MikeMcC399 ba01633
doc: fix typo in devcontainer guide
Rohan5commit 1b1eb9e
build: remove redundant -fuse-linker-plugin from GCC LTO flags
robertsLando dfb9ede
stream: allow shared array buffer sources in writable webstream adapter
Renegade334 06c405f
src: coerce `spawnSync` args to string once
aduh95 f7bd9e3
tools: update gyp-next to 0.22.0
nodejs-github-bot f218a4f
deps: update nbytes to 0.1.4
nodejs-github-bot 6cd368b
deps: update sqlite to 3.53.0
nodejs-github-bot 63c111c
fs: validate position argument before length === 0 early return
geeksilva97 ce47ea3
doc: clarify process._debugProcess() in Permission Model
cybe4sent1nel 3d18162
lib: reject SharedArrayBuffer in web APIs per spec
thisalihassan 3527646
stream: fix nested compose error propagation
mcollina 795db76
meta: pass release version to release worker
flakey5 314dacd
lib: improve Web Cryptography key validation ordering
panva 2d63638
url: align default argument handling for URLPattern with webidl
panva 87443b4
node-api: execute tsfn finalizer after queue drains when aborted
KevinEady 01090f2
node-api: add napi_create_external_sharedarraybuffer
bnoordhuis c22d341
test: check contextify contextual store behavior in strict mode
Renegade334 6b7280b
doc: add experimental modules lifetime policy
ShogunPanda 9b95c41
lib: fix sequence argument handling in Blob constructor
Ms2ger 978f5c1
stream: simplify `readableStreamFromIterable`
aduh95 5e14e4d
meta: broaden stale bot
avivkeller 3ba0add
lib: fix lint in internal/webstreams/util.js
panva c70ff44
src: use context-free V8 message column getters
Renegade334 430c69d
lib: use js-only implementation of `isDataView()`
Renegade334 a932fbd
tools: re-enable undici WPTs in daily wpt.fyi job
panva ddf1f01
esm: add `ERR_REQUIRE_ESM_RACE_CONDITION`
aduh95 8637524
test: mark test-snapshot-reproducible flaky
panva ec2451b
debugger: add edit-free runtime expression probes to `node inspect`
joyeecheung bfc1319
tools: exclude @node-core/doc-kit from dependabot cooldown
kxxt 9c700f3
doc: clarify dns.lookup() callback signature when all is true
galaxy4276 841dfbf
node-api: update libuv ABI stability note
legendecas afdd355
test: update test/addons/openssl-binding for OpenSSL 4.0
panva 947f1ae
test: accept renamed OpenSSL 4.0 error code and reason
panva 3aa9938
test: skip test-tls-error-stack when engines are unsupported
panva 036bc6f
test: use valid DER OCSP responses
panva 698d828
test: use an always invalid cipher and cover OpenSSL 4.0 behaviours
panva 375a993
test: skip tls-deprecated secp256k1 on OpenSSL 4.0
panva b7fdd94
test: account for RFC 7919 FFDHE negotiation in OpenSSL 4.0
panva 0fba9e8
doc: remove Ayase-252 and meixg from triagger team
aduh95 cd9890a
src: fix MaybeStackBuffer char_traits deprecation warning
omghante 94433e4
doc,src,test: fix dead inspector help URL
semimikoh ef7ffce
src: use DCHECK in AsyncWrap::MakeCallback instead emiting a warning
Flarna 9a3a190
doc: clarify diffieHellman.generateKeys recomputes same key
kovan d0c9137
stream: ensuring cross-destruction in _duplexify to prevent leaks
watilde cfb1fa9
stream: reject duplicate nested transferables
daeyeon cd7e262
tools: bump brace-expansion in /tools/clang-format
dependabot[bot] 00e86f0
tools: bump brace-expansion from 5.0.4 to 5.0.5 in /tools/eslint
dependabot[bot] 13b7d08
module: remove duplicated checks from `_resolveFilename`
aduh95 37d3913
lib: short-circuit WebIDL BufferSource SAB check
panva f503675
meta: bump actions/setup-node from 6.3.0 to 6.4.0
dependabot[bot] 0253c6e
meta: bump step-security/harden-runner from 2.16.1 to 2.19.0
dependabot[bot] 1e2915c
meta: bump peter-evans/create-pull-request from 8.1.0 to 8.1.1
dependabot[bot] a47ea6d
tools: set bot as author of tools-deps-update PRs
aduh95 59e7fb7
meta: move VoltrexKeyva to emeritus
mcollina 01a9552
test_runner: add mock-timers support for AbortSignal.timeout
DeveloperViraj f4ea495
fs: restore fs patchability in ESM loader
joyeecheung 3e72065
test_runner: fix suite rerun edge case
MoLow 5c4798d
http: fix no_proxy leading-dot suffix matching
watilde 169b5ea
doc: fix Argon2 parameter bounds
tniessen eeae754
crypto: reject inherited key type names
JonathanLopes404 25d2e99
lib: harden kKeyOps lookup with null prototype
panva da4dd86
test: normalize known inspector crash as completion
joyeecheung d142c58
test_runner: align mock timeout api
Han5991 64f15c2
http: fix leaked error listener on sync HTTP req create + destroy
pimterry 1a60851
doc: fix typo in dns.lookup options description
watilde 01dfe59
deps: cherry-pick libuv/libuv@439a54b
skooch 24a0781
stream: validate ReadableStream.from iterator objects
daeyeon e95570c
process: handle rejections only when needed
gurgunday 7bd08ff
url: optimize URLSearchParams set/delete duplicate handling
gurgunday 6e097ee
tools: consolidate and simplify .editorconfig deps section
watilde 46c99ed
doc: fix duplicate word "for for" in compile cache
watilde ca02af1
doc: fix duplicate word "of of" in postMessageToThread
watilde b5ca5ad
src: simplify `TCPWrap::Connect` signature
addaleax 09e17fe
meta: add automation policy
legendecas 76f21c5
doc: correct typo in PR contribution instructions
MikeMcC399 3e10365
deps: upgrade npm to 11.13.0
npm-cli-bot 97e32c7
lib: avoid quadratic shift() in startup snapshot callback
watilde c23db1c
tools: fix commit linter for semver-major release proposals
aduh95 16e8c2b
crypto: fix unsigned conversion of 4-byte RSA publicExponent
deepview-autofix ef413b5
doc: fix typo in test.md
Trott 9354bf4
tools: update gyp-next to 0.22.1
nodejs-github-bot 14a4cb8
deps: update timezone to 2026b
nodejs-github-bot 0e2adb3
watch: track worker entry files in watch mode
SudhansuBandha b6219b6
src: fix crash in GetErrorSource() for invalid using syntax
semimikoh a0f9000
test: export isRiscv64 from common module
JamieMagee 137e09c
deps: update corepack to 0.34.7
nodejs-github-bot 4d396ac
tools: bump the eslint group in /tools/eslint with 4 updates
dependabot[bot] 2a9ccc9
doc: use mjs/cjs blocks for callbackify null reason example
watilde 5d97919
doc: correct diagnostics_channel built-in channel names
bengl ecb4d49
src: add missing <cstdlib> for abort() declaration
ckerr 900dc75
http2: expose writable stream state on compat response
cookesan 9a25fc8
url: process crash via malformed UNC hostname in pathToFileURL()
NickNaso 4bf8584
debugger: move ProbeInspectorSession and helpers to separate files
joyeecheung 04d3538
tools: do not run `test-linux` on unrelated tools changes
aduh95 ff86b1d
stream: simplify `setPromiseHandled` utility
aduh95 b133019
tools: simplify `update-undici.sh`
aduh95 62fe0cf
deps: update llhttp to 9.4.1
nodejs-github-bot 1718bc3
inspector: fix absolute URLs in network http
GrinZero 91a07cf
meta: bump Mozilla-Actions/sccache-action from 0.0.9 to 0.0.10
dependabot[bot] 7cd2066
meta: bump github/codeql-action from 4.35.1 to 4.35.3
dependabot[bot] 99bb02f
src: swap dotenv and config file parsing order
marco-ippolito 5a93bde
tools: update gr2m/create-or-update-pull-request-action to v1.10.1
MikeMcC399 d7188af
http: harden ClientRequest options merge
mcollina 1397d8c
stream: remove duplicated utility
aduh95 717476a
http: emit 'drain' on OutgoingMessage only after buffers drain
ronag 7792f1a
stream: copyedit `webstreams/adapter.js`
aduh95 add94f4
build: track PDL files as inputs in inspector GN build
deepak1556 5b49178
tools: use LTS Node.js in notify-on-push workflow
nsinfoPRO 8b3a4fc
deps: update amaro to 1.1.9
nodejs-github-bot 60c83f6
test_runner: fix failing suite hooks when marked with `todo`
MoLow 233894a
doc: fix the TypeScript Execute (tsx) project link
davidthornton 5556b15
quic: start re-enabling quic with openssl 3.5
jasnell 1d00313
deps: update ngtcp2 to 1.14.0
jasnell e073b38
deps: update nghttp3 to 1.11.0
jasnell b2b0bf8
quic: update the guard to check openssl version
jasnell 6df1508
quic: fixup windows coverage compile error
jasnell 6553202
quic: fixup NO_ERROR macro conflict on windows
jasnell ca0080c
quic: few additional small comment edits in cid.h
jasnell b91a934
quic: update more of the quic to the new compile guard
jasnell 3be70ff
quic: multiple fixups and updates
jasnell a31a8ee
quic: reduce boilerplate and other minor cleanups
jasnell c9d4a44
src: cleanup quic TransportParams class
jasnell f49175b
src: fix small compile warning in quic/streams.cc
jasnell 5304db9
deps: update nghttp3 to 1.13.1
nodejs-github-bot 722c0c3
deps: update nghttp3 to 1.14.0
nodejs-github-bot 45c1ebd
quic: copy options.certs buffer instead of detaching
legendecas 7f3a85e
quic: fix a handful of bugs and missing functionality
jasnell edeed43
quic: update http3 impl details
jasnell 21e9239
quic: fixup linting/formatting issues
jasnell ea4f19a
quic: use arena allocation for packets
jasnell 08726cd
quic: move quic behind compile time flag
mcollina 76d9c24
quic: implement rapidhash for hashing improvements
jasnell 28c4f44
src: add permission support to config file
marco-ippolito f50ac5b
test: improve config-file permission test coverage
RafaelGSS dca1e6a
src: expose help texts into node-config-schema.json
pmarchini 3f74a58
test_runner: update node-config-schema
pmarchini b6378e2
doc: fix node-config-schema
ChALkeR b2981ec
meta: bump actions/download-artifact from 8.0.0 to 8.0.1
dependabot[bot] 476926c
quic: apply multiple TLS context improvements and SNI support
jasnell abb881e
quic: support multiple ALPN negotiation
jasnell c128942
quic: fixup token verification to handle zero expiration
jasnell 00705a4
util: colorize text with hex colors
araujogui f697c55
quic: add QuicEndpoint.listening & QuicStream.destroy() and tests
pimterry a12dc44
tools: add a check for clean git tree after tests
aduh95 dafed45
src: clean up experimental flag variables
aduh95 4a506ac
fs: add followSymlinks option to glob
mcollina f2a1735
doc: fix duplicate word "to to" in util.styleText
watilde d0d19bd
test: update WPT for streams to f8f26a372f
nodejs-github-bot 31a863f
test: update WPT for url to 258f285de0
nodejs-github-bot 2ca42c8
repl: keep reference count for `process.on('newListener')`
addaleax 28a7874
crypto: remove Argon2 KDF derivation from its job setup
panva 341947e
crypto: reject unintended raw key format string input
panva aa1e0bc
doc: fix typos and inconsistencies in crypto.md and webcrypto.md
panva 8752b60
crypto: deduplicate and canonicalize CryptoKey usages
panva 36cc041
inspector: initial support storage inspection
islandryu 4f3f21b
inspector: auto collect webstorage data
islandryu 3dc3fb6
inspector: return errors when CDP protocol event emission fails
islandryu b3bfe35
inspector: coerce key and value to string in webstorage events
thisalihassan b881658
test: generate `localstorage.db` in a temp dir
legendecas ec8c6b9
deps: V8: cherry-pick 657d8de27427
guybedford d14029b
test_runner: support test order randomization
pmarchini 5c27704
test_runner: publish to TracingChannel for OTel instrumentation
MoLow f68189b
test_runner: add `testId` to test events
MoLow 83e98f7
deps: update corepack to 0.35.0
nodejs-github-bot c7d1015
2026-05-21, Version 24.16.0 'Krypton' (LTS)
nodejs-github-bot b5071ed
Merge tag 'v24.16.0' into node-v24.16.0-nsolid-v6.3.0-release
santigimeno 3ce4689
2026-06-15, Version 24.16.0-nsolid-v6.3.0 'Krypton'
santigimeno File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| name: Run undici WPT (current) | ||
| description: Runs undici WPT tests for undici >= 7 and merges results into the Node.js WPT report | ||
|
|
||
| inputs: | ||
| undici-version: | ||
| required: true | ||
| description: undici version tag to checkout | ||
| wpt-report: | ||
| required: true | ||
| description: Path to the Node.js WPT report to merge into | ||
|
|
||
| runs: | ||
| using: composite | ||
| steps: | ||
| - name: Checkout undici | ||
| uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 | ||
| with: | ||
| repository: nodejs/undici | ||
| persist-credentials: false | ||
| path: undici | ||
| clean: false | ||
| ref: ${{ inputs.undici-version }} | ||
| - name: Prepare WPT checkout | ||
| shell: bash | ||
| run: | | ||
| rm -rf undici/test/web-platform-tests/wpt | ||
| mv test/fixtures/wpt undici/test/web-platform-tests/wpt | ||
| - name: Configure hosts | ||
| shell: bash | ||
| working-directory: undici/test/web-platform-tests/wpt | ||
| run: python3 wpt make-hosts-file | sudo tee -a /etc/hosts | ||
| - name: Install dependencies | ||
| shell: bash | ||
| working-directory: undici | ||
| run: npm install | ||
| - name: Run WPT | ||
| shell: bash | ||
| working-directory: undici | ||
| env: | ||
| CI: 'true' | ||
| WPT_REPORT: ${{ github.workspace }}/undici/wptreport.json | ||
| run: npm run test:wpt || true | ||
| - name: Merge report | ||
| shell: bash | ||
| env: | ||
| NODE_WPT_REPORT: ${{ inputs.wpt-report }} | ||
| UNDICI_WPT_REPORT: ${{ github.workspace }}/undici/wptreport.json | ||
| run: | | ||
| if [ -f "$UNDICI_WPT_REPORT" ]; then | ||
| jq -sc ' | ||
| .[0].results += .[1].results | | ||
| .[0].time_end = .[1].time_end | | ||
| .[0] | ||
| ' "$NODE_WPT_REPORT" "$UNDICI_WPT_REPORT" > "${NODE_WPT_REPORT}.tmp" | ||
| mv "${NODE_WPT_REPORT}.tmp" "$NODE_WPT_REPORT" | ||
| fi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| name: Run undici WPT (legacy) | ||
| description: Runs undici WPT tests for undici < 7 and appends results to the Node.js WPT report | ||
|
|
||
| inputs: | ||
| undici-version: | ||
| required: true | ||
| description: undici version tag to checkout | ||
| wpt-report: | ||
| required: true | ||
| description: Path to the Node.js WPT report | ||
|
|
||
| runs: | ||
| using: composite | ||
| steps: | ||
| - name: Checkout undici | ||
| uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 | ||
| with: | ||
| repository: nodejs/undici | ||
| persist-credentials: false | ||
| path: undici | ||
| clean: false | ||
| ref: ${{ inputs.undici-version }} | ||
| - name: Prepare WPT checkout | ||
| shell: bash | ||
| run: | | ||
| rm -rf undici/test/wpt/tests | ||
| mv test/fixtures/wpt undici/test/wpt/tests | ||
| - name: Install dependencies | ||
| shell: bash | ||
| working-directory: undici | ||
| run: npm install | ||
| - name: Run WPT | ||
| shell: bash | ||
| working-directory: undici | ||
| env: | ||
| WPT_REPORT: ${{ inputs.wpt-report }} | ||
| run: npm run test:wpt || true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🌐 Web query:
In GitHub Actionson.pull_request.branchesmatching, doesv[0-9]+.x-stagingtreat+as a regex quantifier or a literal character? Would it matchv24.x-staging?💡 Result:
In GitHub Actions, the
on.pull_request.branchesfilter uses glob patterns rather than regular expressions [1][2]. The+character is treated as a literal character in this context unless it is intended to function as part of a glob pattern (where it is specifically listed as a special character that may require escaping for literal matches) [1]. Because GitHub Actions uses glob matching, your patternv[0-9]+.x-stagingwill not function as a regex that matches "one or more digits". Instead, it will be evaluated as a glob pattern that literally looks for the characters[,0,-,9,],+,.,x,-,s,t,a,g,i,n,g[1]. It would not matchv24.x-staging. If you need to match branch names using regex, you should not use thebranchesfilter directly [3][4]. Instead, you can: 1. Use a standardon.pull_requesttrigger without branch filters (or with broad filters). 2. Add a job with anifconditional that uses thegithub.ref_nameorgithub.event.pull_request.head.refcontext along with a regex evaluation [3][5]. Since GitHub Actions expressions do not have a built-inmatchesorregexfunction for strings, you can use thecontainsfunction for simple logic [5] or use a dedicated third-party action that supports regex matching to perform the validation [6][7].Citations:
Fix PR branch glob pattern in
.github/workflows/commit-lint.ymlGitHub Actions
on.pull_request.branchesuses glob patterns, not regex. The valuev[0-9]+.x-stagingwon’t be interpreted as “one or more digits” (so it won’t matchv24.x-staging), which can cause PRs to the staging branches to be missed. Use a glob likev*.x-staginginstead.Suggested fix
branches: - main - - v[0-9]+.x-staging + - v*.x-staging📝 Committable suggestion
🤖 Prompt for AI Agents