Node v24.15.0 nsolid v6.2.5 release - #479
Conversation
Addresses `GHSA-ph9p-34f9-6g65`. Signed-off-by: Santiago Gimeno <santiago.gimeno@gmail.com> PR-URL: #478 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
WalkthroughThis PR prepares a release by updating the ncm-ng dependency to 2.9.9, bumping the tmp dependency to ^0.2.6, enabling the release flag in the version header, and documenting these changes in the changelog for version 24.15.0-nsolid-v6.2.5 'Krypton'. ChangesRelease v24.15.0-nsolid-v6.2.5 Krypton
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
doc/changelogs/NSOLID_CHANGELOG_V6_NODE_V24.md (1)
5-10: ⚡ Quick winConsider mentioning the security fix in the changelog.
The PR objectives indicate that the ncm-ng update to 2.9.9 addresses vulnerability GHSA-ph9p-34f9-6g65. Consider adding this security context to the changelog entry to help users understand the importance of this release.
📝 Suggested enhancement
### Commits -* \[[`47e5a9ed2e`](https://github.com/nodesource/nsolid/commit/47e5a9ed2e)] - **deps**: update ncm-ng to 2.9.9 (Minwoo) [`#478`](https://github.com/nodesource/nsolid/pull/478) +* \[[`47e5a9ed2e`](https://github.com/nodesource/nsolid/commit/47e5a9ed2e)] - **deps**: update ncm-ng to 2.9.9 to address GHSA-ph9p-34f9-6g65 (Minwoo) [`#478`](https://github.com/nodesource/nsolid/pull/478)🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@doc/changelogs/NSOLID_CHANGELOG_V6_NODE_V24.md` around lines 5 - 10, Update the changelog entry for "2026-06-11, Version 24.15.0-nsolid-v6.2.5 'Krypton'" to explicitly state that the deps bump of ncm-ng to 2.9.9 (commit 47e5a9ed2e) addresses vulnerability GHSA-ph9p-34f9-6g65; add one concise sentence after the existing bullet (or augment the bullet) indicating the security fix and its CVE/GHSA identifier so users know this release resolves that vulnerability.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@doc/changelogs/NSOLID_CHANGELOG_V6_NODE_V24.md`:
- Around line 5-10: Update the changelog entry for "2026-06-11, Version
24.15.0-nsolid-v6.2.5 'Krypton'" to explicitly state that the deps bump of
ncm-ng to 2.9.9 (commit 47e5a9ed2e) addresses vulnerability GHSA-ph9p-34f9-6g65;
add one concise sentence after the existing bullet (or augment the bullet)
indicating the security fix and its CVE/GHSA identifier so users know this
release resolves that vulnerability.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: e2b66c0e-fe22-4400-b099-a062b37f0fda
📒 Files selected for processing (3)
deps/ncm-ng/package.jsondoc/changelogs/NSOLID_CHANGELOG_V6_NODE_V24.mdsrc/node_version.h
Summary by CodeRabbit
Chores
Documentation