Skip to content

Node v24.15.0 nsolid v6.2.5 release - #479

Closed
santigimeno wants to merge 2 commits into
node-v24.x-nsolid-v6.xfrom
node-v24.15.0-nsolid-v6.2.5-release
Closed

Node v24.15.0 nsolid v6.2.5 release#479
santigimeno wants to merge 2 commits into
node-v24.x-nsolid-v6.xfrom
node-v24.15.0-nsolid-v6.2.5-release

Conversation

@santigimeno

@santigimeno santigimeno commented Jun 10, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Chores

    • Updated internal dependencies to latest compatible versions.
  • Documentation

    • Added changelog documentation for version 24.15.0-nsolid-v6.2.5 'Krypton'.

JungMinu and others added 2 commits June 10, 2026 23:37
Addresses `GHSA-ph9p-34f9-6g65`.

Signed-off-by: Santiago Gimeno <santiago.gimeno@gmail.com>
PR-URL: #478
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
@santigimeno
santigimeno requested a review from RafaelGSS June 10, 2026 21:39
@santigimeno santigimeno self-assigned this Jun 10, 2026
@coderabbitai

coderabbitai Bot commented Jun 10, 2026

Copy link
Copy Markdown

Review Change Stack

Walkthrough

This PR prepares a release by updating the ncm-ng dependency to 2.9.9, bumping the tmp dependency to ^0.2.6, enabling the release flag in the version header, and documenting these changes in the changelog for version 24.15.0-nsolid-v6.2.5 'Krypton'.

Changes

Release v24.15.0-nsolid-v6.2.5 Krypton

Layer / File(s) Summary
Dependency updates and release flag
deps/ncm-ng/package.json, src/node_version.h
Package version bumped from 2.9.8 to 2.9.9, tmp dependency updated from ^0.2.1 to ^0.2.6, and NSOLID_VERSION_IS_RELEASE flag changed from 0 to 1 to enable release mode.
Release changelog entry
doc/changelogs/NSOLID_CHANGELOG_V6_NODE_V24.md
New release section added documenting version 24.15.0-nsolid-v6.2.5 'Krypton' with commit entry for the ncm-ng 2.9.9 upgrade.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • nodesource/nsolid#478: Contains identical dependency changes to deps/ncm-ng/package.json (ncm-ng 2.9.9 and tmp ^0.2.6).
  • nodesource/nsolid#461: Also flips NSOLID_VERSION_IS_RELEASE from 0 to 1 in src/node_version.h to mark a release build.
  • nodesource/nsolid#397: Updates both src/node_version.h release flag and doc/changelogs/NSOLID_CHANGELOG_V6_NODE_V24.md with ncm-ng version entry.

Suggested reviewers

  • RafaelGSS
  • juanarbol

🐰 A carrot of a release, so fine and bright,
Dependencies bumped, the version flag set right,
Changelog singing of Krypton's new way,
All systems aligned for the launch day! 🚀

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and directly describes the main change: a release of Node v24.15.0 with N|Solid v6.2.5, which matches the changeset's version bumps, dependency updates, and release marker.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch node-v24.15.0-nsolid-v6.2.5-release

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
doc/changelogs/NSOLID_CHANGELOG_V6_NODE_V24.md (1)

5-10: ⚡ Quick win

Consider mentioning the security fix in the changelog.

The PR objectives indicate that the ncm-ng update to 2.9.9 addresses vulnerability GHSA-ph9p-34f9-6g65. Consider adding this security context to the changelog entry to help users understand the importance of this release.

📝 Suggested enhancement
 ### Commits
 
-* \[[`47e5a9ed2e`](https://github.com/nodesource/nsolid/commit/47e5a9ed2e)] - **deps**: update ncm-ng to 2.9.9 (Minwoo) [`#478`](https://github.com/nodesource/nsolid/pull/478)
+* \[[`47e5a9ed2e`](https://github.com/nodesource/nsolid/commit/47e5a9ed2e)] - **deps**: update ncm-ng to 2.9.9 to address GHSA-ph9p-34f9-6g65 (Minwoo) [`#478`](https://github.com/nodesource/nsolid/pull/478)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@doc/changelogs/NSOLID_CHANGELOG_V6_NODE_V24.md` around lines 5 - 10, Update
the changelog entry for "2026-06-11, Version 24.15.0-nsolid-v6.2.5 'Krypton'" to
explicitly state that the deps bump of ncm-ng to 2.9.9 (commit 47e5a9ed2e)
addresses vulnerability GHSA-ph9p-34f9-6g65; add one concise sentence after the
existing bullet (or augment the bullet) indicating the security fix and its
CVE/GHSA identifier so users know this release resolves that vulnerability.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@doc/changelogs/NSOLID_CHANGELOG_V6_NODE_V24.md`:
- Around line 5-10: Update the changelog entry for "2026-06-11, Version
24.15.0-nsolid-v6.2.5 'Krypton'" to explicitly state that the deps bump of
ncm-ng to 2.9.9 (commit 47e5a9ed2e) addresses vulnerability GHSA-ph9p-34f9-6g65;
add one concise sentence after the existing bullet (or augment the bullet)
indicating the security fix and its CVE/GHSA identifier so users know this
release resolves that vulnerability.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e2b66c0e-fe22-4400-b099-a062b37f0fda

📥 Commits

Reviewing files that changed from the base of the PR and between e9d6fc1 and 4be629b.

📒 Files selected for processing (3)
  • deps/ncm-ng/package.json
  • doc/changelogs/NSOLID_CHANGELOG_V6_NODE_V24.md
  • src/node_version.h

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants