Issue #3004866 by tarekdj: Fix failing tests#33
Open
tarekdj wants to merge 24 commits intonodespark:8.x-6.xfrom
Open
Issue #3004866 by tarekdj: Fix failing tests#33tarekdj wants to merge 24 commits intonodespark:8.x-6.xfrom
tarekdj wants to merge 24 commits intonodespark:8.x-6.xfrom
Conversation
Author
|
@nignatov tests are passing on my local setup. On circle-ci we have issues with Kernel tests. I'm not sure but I think it's related to https://www.drupal.org/node/2931730. |
tarekdj
changed the title
Author
|
OK! I think we are done here. Behat , Unit and Kernel tests are passing. I think we can skip code coverage and cs checking. |
Closed
|
Tests are no longer passing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a work in progress...