Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set kwargs to any #19

Merged
merged 2 commits into from
Mar 20, 2025
Merged

fix: set kwargs to any #19

merged 2 commits into from
Mar 20, 2025

Conversation

jbristow
Copy link
Contributor

@jbristow jbristow commented Mar 20, 2025

Summary of Change

It turns out that I assumed wrong, and **x: dict[str, Any] means that x is hinted to be a dict[str, dict[str, Any]] 🤦

Before Review

  • Unit Tests are Added/Updated and meet at-least 85% coverage criteria for that feature

Before Merge

  • Ran/Functionally Tested in Dev Environment
  • Documentation Is Updated (Where Appropriate)

Copy link
Contributor

github-actions bot commented Mar 20, 2025

Coverage

Coverage Report
FileStmtsMissCoverMissing
nodestream_github
   plugin.py4175%6
   repos.py80396%30, 70, 74
   teams.py34197%63
nodestream_github/client
   githubclient.py2443088%93–94, 99–100, 193, 211, 247, 264, 330–331, 358–359, 420–421, 441–442, 477–478, 499–500, 512–513, 533–534, 543–544, 571–572, 592–593
TOTAL5593594% 

Tests Skipped Failures Errors Time
34 0 💤 0 ❌ 0 🔥 1.716s ⏱️

rreddy2
rreddy2 previously approved these changes Mar 20, 2025
@jbristow jbristow merged commit 0dbadba into master Mar 20, 2025
4 checks passed
@jbristow jbristow deleted the type-fixing-2 branch March 20, 2025 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants