Skip to content

fix(accessibility): add alternate text to .gm-resize-trigger object #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kristinita wants to merge 5 commits into
base: master
Choose a base branch
from
Open

fix(accessibility): add alternate text to .gm-resize-trigger object #67

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7e61266
perf(minify): minify CSS and JavaScript
May 8, 2018
fd4400b
fix(accessibility): add text content to .gm-resize-trigger object
Kristinita Sep 23, 2020
c37a299
fix(css): remove !important anti-pattern — https://dev.to/alvaromonto…
Kristinita Sep 17, 2022
1a1cc17
revert(min): remove minification files because jsDelivr minifies file…
Kristinita Dec 13, 2023
b1ab0ca
fix(validation): add aria-label attribute for object
Kristinita Dec 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gemini-scrollbar.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
/* actual gemini-scrollbar styles */
.gm-scrollbar-container {
position: relative;
overflow: hidden!important;
overflow: hidden;
width: 100%;
height: 100%;
}
Expand Down
10 changes: 10 additions & 0 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,16 @@
addClass(obj, [CLASSNAMES.resizeTrigger]);
obj.type = 'text/html';
obj.setAttribute('tabindex', '-1');
/* [INFO] Required for previous Lighthouse versions,
but not required for Lighthouse 11.4.0:

obj.textContent = 'Resize trigger'; */

/* [INFO] <object> elements must have alternate text:
https://dequeuniversity.com/rules/axe/4.8/object-alt

This attribute required for Lighthouse 11.4.0. */
obj.setAttribute('aria-label', 'Resize trigger');
var resizeHandler = this._resizeHandler.bind(this);
obj.onload = function () {
var win = obj.contentDocument.defaultView;
Expand Down