Skip to content

Conversation

@sipsorcery
Copy link
Member

No description provided.

@sipsorcery sipsorcery changed the base branch from master to develop June 30, 2025 22:08

This comment was marked as outdated.

@sipsorcery sipsorcery requested a review from Copilot June 30, 2025 22:10
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses the fix for the fx display tests by updating expected output values in the unit tests and refining logic in the payout model. Key changes include:

  • Updating expected formatted fx destination amounts in tests.
  • Changing the test data for FxDestinationAmount to use an explicit value rather than a computed one.
  • Fixing a documentation typo in the Payout model.
  • Adding a currency mapping for CurrencyTypeEnum.None in CurrencyExtensions.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
test/MoneyMoov.UnitTests/Models/PayoutTests.cs Updated expected test outputs for formatted fx display and revised test logic for explicit FxDestinationAmount values.
src/NoFrixion.MoneyMoov/Models/Payouts/Payout.cs Fixed a documentation typo regarding FxDestinationAmount.
src/NoFrixion.MoneyMoov/Extensions/CurrencyExtensions.cs Added a mapping for CurrencyTypeEnum.None to return "?".
Comments suppressed due to low confidence (2)

test/MoneyMoov.UnitTests/Models/PayoutTests.cs:46

  • Ensure that updating the expected formatted fx destination amount to include a currency symbol when inputs are null is intentional; consider adding a brief comment or updating the test method name to clarify this behavior change.
        Assert.Equal("? 100.00", payout.FormattedFxDestinationAmount);

test/MoneyMoov.UnitTests/Models/PayoutTests.cs:118

  • Confirm that explicitly setting FxDestinationAmount now takes precedence over calculating the value using Amount and FxRate, and update related documentation or test descriptions accordingly to reflect the new business logic.
            FxDestinationAmount = 82.5m,

@sipsorcery sipsorcery merged commit 269c077 into develop Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants