Removed the range validation attribute from the FxDestinationAmount. #654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sipsorcery
requested review from
arifmatin,
donalnofrixion and
sauravmaiti22
sauravmaiti22
approved these changes
Sep 23, 2025
donalnofrixion
approved these changes
Sep 23, 2025
sipsorcery
added a commit
that referenced
this pull request
Sep 23, 2025
* Removed the range validation attribute from the FxDestinationAmount. (#654) * Remove redundant Tribe field from create payment account, was causing confusion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The attribute meant that if a caller supplied an FxDestinationAmount of 0 it would always fail validtion even if the filed was not being used.